Skip to content

fix(engine): closing of connection pool #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishwarajanand merged 2 commits into from
Mar 24, 2025
Merged

fix(engine): closing of connection pool #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81110ab
fix(engine): closing of connection pool
averikitsch Mar 23, 2025
d4ccae0
Merge branch 'main' into averikitsch-patch-2
averikitsch Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/llama_index_cloud_sql_pg/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ def _run_as_sync(self, coro: Awaitable[T]) -> T:

async def close(self) -> None:
"""Dispose of connection pool"""
await self._pool.dispose()
await self._run_as_async(self._pool.dispose())

async def _ainit_doc_store_table(
self,
Expand Down