This repository was archived by the owner on Oct 3, 2023. It is now read-only.
docs(samples): Refactoring product package (Import) #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
4 tasks
chenlei1216
approved these changes
Apr 25, 2022
alicejli
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
alicejli
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
averikitsch
approved these changes
Aug 12, 2022
| String gcsBucket = String.format("gs://%s", System.getenv("BUCKET_NAME")); | ||
| String gcsErrorBucket = String.format("%s/errors", gcsBucket); | ||
| String bucketName = System.getenv("BUCKET_NAME"); | ||
| String gcsBucket = String.format("gs://%s", bucketName); |
There was a problem hiding this comment.
nit: is there not a helper method for this?
averikitsch
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Contributor
|
I believe these files already exist in https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/retail/interactive-tutorials/src/main/java, hence closing this. Please re-open if otherwise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.