Skip to content

Conversation

@cloud-java-bot
Copy link
Collaborator

@cloud-java-bot cloud-java-bot commented Jun 4, 2025

This pull request is generated with proto changes between googleapis/googleapis@5e49af8 (exclusive) and googleapis/googleapis@de157ca (inclusive).

BEGIN_COMMIT_OVERRIDE
BEGIN_NESTED_COMMIT
fix(deps): update the Java code generator (gapic-generator-java) to 2.59.0
END_NESTED_COMMIT
END_COMMIT_OVERRIDE

@cloud-java-bot cloud-java-bot requested review from a team as code owners June 4, 2025 02:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 4, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jun 4, 2025
@zhumin8
Copy link
Contributor

zhumin8 commented Jun 4, 2025

ci/units (24) is newly added, failed with:

Error:  Tests run: 30, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.47 s <<< FAILURE! -- in com.google.cloud.pubsub.v1.PublisherImplTest
Error:  com.google.cloud.pubsub.v1.PublisherImplTest.testShutDown -- Time elapsed: 0.404 s <<< ERROR!
java.lang.IllegalArgumentException: Could not create type
	at org.easymock.bytebuddy.TypeCache.findOrInsert(TypeCache.java:170)
        ... ...
Caused by: java.lang.IllegalArgumentException: com.google.cloud.pubsub.v1.Publisher$$$EasyMock$1 must be defined in the same package as org.easymock.internal.ClassProxyFactory

wonder this was seen in updating jdk24 in last cycle?
@ldetmer @mpeddada1

Update:
Attempted locally to upgrade easymock to 5.5.0 and 5.6.0 that support JDK 24, still did not fix this error.

@cloud-java-bot cloud-java-bot changed the title chore: Update generation configuration at Wed Jun 4 02:34:46 UTC 2025 chore: Update generation configuration at Thu Jun 5 02:34:31 UTC 2025 Jun 5, 2025
@ldetmer
Copy link
Contributor

ldetmer commented Jun 5, 2025

ci/units (24) is newly added, failed with:

Error:  Tests run: 30, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.47 s <<< FAILURE! -- in com.google.cloud.pubsub.v1.PublisherImplTest
Error:  com.google.cloud.pubsub.v1.PublisherImplTest.testShutDown -- Time elapsed: 0.404 s <<< ERROR!
java.lang.IllegalArgumentException: Could not create type
	at org.easymock.bytebuddy.TypeCache.findOrInsert(TypeCache.java:170)
        ... ...
Caused by: java.lang.IllegalArgumentException: com.google.cloud.pubsub.v1.Publisher$$$EasyMock$1 must be defined in the same package as org.easymock.internal.ClassProxyFactory

wonder this was seen in updating jdk24 in last cycle? @ldetmer @mpeddada1

Update: Attempted locally to upgrade easymock to 5.5.0 and 5.6.0 that support JDK 24, still did not fix this error.

it looks like downstream tests in original PR are only testing against the main version of java (17)

@zhumin8
Copy link
Contributor

zhumin8 commented Jun 5, 2025

We are proceeding with release, without enforcing JDK24/GraalVM24 compatibility for this cycle.
Skipping any issue in ci/units(24) for now.

@zhumin8 zhumin8 merged commit 0eece50 into main Jun 5, 2025
27 of 28 checks passed
@zhumin8 zhumin8 deleted the generate-libraries-main branch June 5, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants