Skip to content

fix: Add documentation to bulkReadRows that each batch will process t… #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 3 commits into from
Sep 14, 2020
Merged

fix: Add documentation to bulkReadRows that each batch will process t… #410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c4987
fix: Add documentation to bulkReadRows that each batch will process t…
dmitry-fa Sep 8, 2020
d06b02a
fix: Add documentation to bulkReadRows that each batch will process t…
dmitry-fa Sep 9, 2020
8c9a077
fix: Add documentation to bulkReadRows that each batch will process t…
dmitry-fa Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...d-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
* // One instance per application.
* BigtableTableAdminClient client = BigtableTableAdminClient.create("[PROJECT]", "[INSTANCE]");
*
* CreateTable request =
* CreateTableRequest request =
* CreateTableRequest.of("my-table")
* .addFamily("cf1")
* .addFamily("cf2", GCRULES.maxVersions(10))
Expand Down
13 changes: 7 additions & 6 deletions ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
* // One instance per application.
* BigtableDataClient client = BigtableDataClient.create("[PROJECT]", "[INSTANCE]")
*
* for(Row row : client.readRows(Query.create("[TABLE]")) {
* for(Row row : client.readRows(Query.create("[TABLE]"))) {
* // Do something with row
* }
*
Expand Down Expand Up @@ -1077,9 +1077,9 @@ public Batcher<RowMutationEntry, Void> newBulkMutationBatcher(@Nonnull String ta
}

/**
* Reads rows for given tableId in a batch. If the row does not exist, the value will be null.
* This operation should be called with in a single thread. The returned Batcher instance is not
* threadsafe, it can only be used from single thread.
* Reads rows for given tableId in a batch. If the row does not exist, the value will be null. The
* keys are processed sequentially one by one in the order they are passed to the Batcher. The
* returned Batcher instance is not threadsafe, it can only be used from a single thread.
*
* <p>Sample Code:
*
Expand Down Expand Up @@ -1113,8 +1113,9 @@ public Batcher<ByteString, Row> newBulkReadRowsBatcher(String tableId) {

/**
* Reads rows for given tableId and filter criteria in a batch. If the row does not exist, the
* value will be null. This operation should be called with in a single thread. The returned
* Batcher instance is not threadsafe, it can only be used from single thread.
* value will be null. The keys are processed sequentially one by one in the order they are passed
* to the Batcher. The returned Batcher instance is not threadsafe, it can only be used from a
* single thread.
*
* <p>Sample Code:
*
Expand Down