Skip to content

fix:add more diagnostic info for test awaitTermination #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephaniewang526 merged 1 commit into from
May 18, 2020
Merged

fix:add more diagnostic info for test awaitTermination #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,17 @@ public void tearDown() throws Exception {
serviceHelper.stop();
}

private StreamWriter.Builder getTestStreamWriterBuilder() {
return StreamWriter.newBuilder(TEST_STREAM)
private StreamWriter.Builder getTestStreamWriterBuilder(String testStream) {
return StreamWriter.newBuilder(testStream)
.setChannelProvider(channelProvider)
.setExecutorProvider(SINGLE_THREAD_EXECUTOR)
.setCredentialsProvider(NoCredentialsProvider.create());
}

private StreamWriter.Builder getTestStreamWriterBuilder() {
return getTestStreamWriterBuilder(TEST_STREAM);
}

private AppendRowsRequest createAppendRequest(String[] messages, long offset) {
AppendRowsRequest.Builder requestBuilder = AppendRowsRequest.newBuilder();
AppendRowsRequest.ProtoData.Builder dataBuilder = AppendRowsRequest.ProtoData.newBuilder();
Expand Down Expand Up @@ -821,9 +825,10 @@ public void testBuilderInvalidArguments() {

@Test
public void testAwaitTermination() throws Exception {
StreamWriter writer = getTestStreamWriterBuilder().build();
StreamWriter writer =
getTestStreamWriterBuilder("projects/p/datasets/d/tables/t/streams/await").build();
testBigQueryWrite.addResponse(AppendRowsResponse.newBuilder().build());
ApiFuture<AppendRowsResponse> appendFuture1 = sendTestMessage(writer, new String[] {"A"});
ApiFuture<AppendRowsResponse> appendFuture1 = sendTestMessage(writer, new String[] {"AWAIT"});
writer.shutdown();
assertTrue(writer.awaitTermination(1, TimeUnit.MINUTES));
}
Expand Down