-
Notifications
You must be signed in to change notification settings - Fork 88
ci: add dependency list completeness check #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephaniewang526
merged 10 commits into
googleapis:master
from
stephaniewang526:dep-completeness
Apr 13, 2020
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
07f44f0
ci: add dependency list completeness check
stephaniewang526 ddaf370
update based on comments
stephaniewang526 becdc17
update based on comments
stephaniewang526 17caced
update based on comments
stephaniewang526 a240430
update based on comments
stephaniewang526 96743f8
update based on comments
stephaniewang526 c647878
update based on comments
stephaniewang526 cd12a64
update based on comments
stephaniewang526 b9790f5
update based on comments
stephaniewang526 03aa928
dump out diff
stephaniewang526 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #!/bin/bash | ||
| # Copyright 2020 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| #set -eo pipefail | ||
|
|
||
| ## Helper functions | ||
| function now() { date +"%Y-%m-%d %H:%M:%S" | tr -d '\n'; } | ||
| function msg() { println "$*" >&2; } | ||
| function println() { printf '%s\n' "$(now) $*"; } | ||
|
|
||
| ## Run dependency list completeness check | ||
stephaniewang526 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| function completenessCheck() { | ||
| # Output dep list with compile scope generated using the original pom | ||
| msg "Generating dependency list using original pom..." | ||
| mvn dependency:list -f pom.xml -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' | grep -v ':test$' >.org-list.txt || true # continue without error if list is empty | ||
stephaniewang526 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # Output dep list generated using the flattened pom (test scope deps are ommitted) | ||
| msg "Generating dependency list using flattened pom..." | ||
| mvn dependency:list -f .flattened-pom.xml -Dsort=true | grep '\[INFO] .*:.*:.*:.*:.*' >.new-list.txt || true # continue without error if list is empty | ||
stephaniewang526 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # Compare two dependency lists | ||
| msg "Comparing dependency lists..." | ||
| diff .org-list.txt .new-list.txt >.diff.txt | ||
| if [[ $? == 0 ]] | ||
| then | ||
| msg "Success. No diff!" | ||
| else | ||
| msg "Diff found. Check .diff.txt file located in $1." | ||
| return 1 | ||
| fi | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.