feat: add enforce linkage checker

[athakor]

Towards #6396

[codecov]

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     58.34%   58.34%           
  Complexity      117      117           
=========================================
  Files            18       18           
  Lines          1145     1145           
  Branches          3        3           
=========================================
  Hits            668      668           
  Misses          475      475           
  Partials          2        2

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62b256...11409ec. Read the comment docs.

[elharo]

We need to fix this before we can turn on this check:

Dependency convergence error for com.google.errorprone:error_prone_annotations:2.3.3 paths to dependency are:
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-io.grpc:grpc-api:1.26.0
+-com.google.errorprone:error_prone_annotations:2.3.3
and
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-com.google.guava:guava:28.2-android
+-com.google.errorprone:error_prone_annotations:2.3.4

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.3.3 paths to dependency are:
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-io.grpc:grpc-api:1.26.0
+-com.google.errorprone:error_prone_annotations:2.3.3
and
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-com.google.guava:guava:28.2-android
+-com.google.errorprone:error_prone_annotations:2.3.4
]

[athakor]

We need to fix this before we can turn on this check:

Dependency convergence error for com.google.errorprone:error_prone_annotations:2.3.3 paths to dependency are:
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-io.grpc:grpc-api:1.26.0
+-com.google.errorprone:error_prone_annotations:2.3.3
and
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-com.google.guava:guava:28.2-android
+-com.google.errorprone:error_prone_annotations:2.3.4

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.errorprone:error_prone_annotations:2.3.3 paths to dependency are:
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-io.grpc:grpc-api:1.26.0
+-com.google.errorprone:error_prone_annotations:2.3.3
and
+-com.google.api.grpc:grpc-google-cloud-asset-v1:0.81.1-SNAPSHOT
+-com.google.guava:guava:28.2-android
+-com.google.errorprone:error_prone_annotations:2.3.4
]

I tried to resolve it but we have to wait until this pr gets merge grpc/grpc-java#6574

[elharo]

Test failure looks related though since it's only on Java 8 maybe you just need to clear caches or some such:

[ERROR] Failed to execute goal on project proto-google-cloud-asset-v1: Could not resolve dependencies for project com.google.api.grpc:proto-google-cloud-asset-v1:jar:0.81.1-SNAPSHOT: Could not transfer artifact com.google.errorprone:error_prone_annotations:jar:2.3.4 from/to central (https://repo.maven.apache.org/maven2): /root/.m2/repository/com/google/errorprone/error_prone_annotations/2.3.4/error_prone_annotations-2.3.4.jar.part (No such file or directory) -> [Help 1]
[ERROR]

[athakor]

@elharo PTAL

[elharo]

This is upper bounds deps, not the linkage checker

[athakor]

This enforcer config is already present in the shared-config since at least version 0.3.0 as can be seen here