Skip to content

fix: recover watch stream on more error types #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crwilcox merged 3 commits into from
Jan 2, 2020
Merged

fix: recover watch stream on more error types #9995

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8b90fb
fix: Recover watch stream on more error types
crwilcox Dec 18, 2019
88d87b6
fix: don't retry deadline exceeded
crwilcox Dec 18, 2019
e2ff234
fix: match recovered stream exceptions to node.js implementation, htt…
crwilcox Dec 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion firestore/google/cloud/firestore_v1/watch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,14 @@
"DO_NOT_USE": -1,
}
_RPC_ERROR_THREAD_NAME = "Thread-OnRpcTerminated"
_RECOVERABLE_STREAM_EXCEPTIONS = (exceptions.ServiceUnavailable,)
_RECOVERABLE_STREAM_EXCEPTIONS = (
exceptions.Unknown,
exceptions.DeadlineExceeded,
exceptions.ResourceExhausted,
exceptions.InternalServerError,
exceptions.ServiceUnavailable,
exceptions.Unauthenticated,
)
_TERMINATING_STREAM_EXCEPTIONS = (exceptions.Cancelled,)

DocTreeEntry = collections.namedtuple("DocTreeEntry", ["value", "index"])
Expand Down