-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Moving storage iterator into core modules. #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. |
dhermes
added a commit
that referenced
this pull request
Jun 23, 2015
Moving storage iterator into core modules.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jun 23, 2015
Error was introduced in googleapis#941 mistakenly.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
parthea
added a commit
that referenced
this pull request
Aug 21, 2025
* feat: Add BigQuery Metastore Partition Service API version v1beta PiperOrigin-RevId: 753333720 Source-Link: googleapis/googleapis@389abd1 Source-Link: googleapis/googleapis-gen@a875887 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTg3NTg4NzkxYWMwMDU3YjViY2Q1YjkxZTQ5N2E1ZGFmZjY2ZWJiYyJ9 * update replacement in owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add gapic_version.py * update gapic_version.py * update docs/index.rst --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
This was referenced Sep 12, 2025
Closed
Closed
parthea
added a commit
that referenced
this pull request
Sep 16, 2025
* feat: Add BigQuery Metastore Partition Service API version v1beta PiperOrigin-RevId: 753333720 Source-Link: googleapis/googleapis@389abd1 Source-Link: googleapis/googleapis-gen@a875887 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTg3NTg4NzkxYWMwMDU3YjViY2Q1YjkxZTQ5N2E1ZGFmZjY2ZWJiYyJ9 * update replacement in owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add gapic_version.py * update gapic_version.py * update docs/index.rst --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <[email protected]>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Generate mock field inputs for all required fields.
* For oneofs, the first option is selected.
* For enums, the last option is selected (as 0 is often unspecified).
* Mock input for string fields that reference resources (`resource_pb2.resource_reference`) is the pattern provided in the protos.
**TODOs:**
- When a resource's pattern is `*` this results in unhelpful strings
```proto
message Asset {
option (google.api.resource) = {
type: "cloudasset.googleapis.com/Asset"
pattern: "*"
};
```
```py
request = asset_v1.BatchGetAssetsHistoryRequest(
parent="*",
)
```
- Map fields are not yet handled.
**Other changes:**
* Fields are set like `foo.bar` rather than through dict access `foo["bar"]`. This is because the former allows you to set fields nested more than one field deep `foo.bar.baz`.
**Before**:
```py
output_config = {}
output_config["gcs_destination"]["uri"] = "uri_value" # fails as there is no nested dict
```
**After**:
```py
output_config = asset_v1.IamPolicyAnalysisOutputConfig()
output_config.gcs_destination.uri = "uri_value"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: core
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.