Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 8, 2015

See #797.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80503a8 on tseaver:797-pubsub-topic_publish_w_timestamp into 41b5b72 on GoogleCloudPlatform:master.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 8, 2015

This is cool :) Thx!

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 627e0de on tseaver:797-pubsub-topic_publish_w_timestamp into f08e71b on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Apr 10, 2015

@dhermes comments addressed, PTAL.

@dhermes
Copy link
Contributor

dhermes commented Apr 10, 2015

LGTM.

tseaver added a commit that referenced this pull request Apr 10, 2015
…tamp

Issue #797: support auto-adding timestamp to pubsub messages.
@tseaver tseaver merged commit 028a15d into googleapis:master Apr 10, 2015
@tseaver tseaver deleted the 797-pubsub-topic_publish_w_timestamp branch April 10, 2015 19:42
parthea pushed a commit that referenced this pull request Aug 21, 2025
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Sep 18, 2025
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <[email protected]>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Certain APIs like RecommendationEngine use multiple enum variant
monikers to reference the same value. Achieving this in protos
requires explicit support from proto-plus and the generated surface.

Hand testing indicates compliance.

Bump the min proto-plus version for generated clients.
parthea pushed a commit that referenced this pull request Nov 24, 2025
That file does not exist and does not seem to appear in the history at all.
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants