Skip to content

Removing Bucket.get_default_object_acl. #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Mar 30, 2015
Merged

Removing Bucket.get_default_object_acl. #772

dhermes merged 1 commit into from
Mar 30, 2015

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@dhermes dhermes mentioned this pull request Mar 28, 2015
Closed
@coveralls
Copy link

coveralls commented Mar 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 0c63f07 on dhermes:remove-get_default_object_acl into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2015
@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM

tseaver
tseaver reviewed Mar 30, 2015
View reviewed changes
gcloud/storage/bucket.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes force-pushed the remove-get_default_object_acl branch from 0c63f07 to f9f5d6f Compare March 30, 2015 19:36
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver Just rebased. Shall we take up the make_public issue elsewhere? It's the last remaining method in #728 without an attached PR.

@coveralls
Copy link

coveralls commented Mar 30, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling f9f5d6f on dhermes:remove-get_default_object_acl into adc0029 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 30, 2015
@dhermes
Merge pull request #772 from dhermes/remove-get_default_object_acl
522987a 
Removing Bucket.get_default_object_acl.
@dhermes dhermes merged commit 522987a into googleapis:master Mar 30, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver I went ahead and merged. Let me know if you want me to revert based on potential issues with make_public. Otherwise we can discuss in #728

@dhermes dhermes deleted the remove-get_default_object_acl branch March 30, 2015 20:02
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@vam-google
fix: fix rest transport tests (#772)
196b94d 
This includes fix fo `data` vs `json` parameter issue and the enum serialization (string instead of number) issue.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.18.1 (#772)
467963a
parthea pushed a commit that referenced this pull request Nov 24, 2025
@zyzniewski
fix: compressed repeated to uncompressed property (#772)
88fc187
parthea pushed a commit that referenced this pull request Nov 25, 2025
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.18.1 (#772)
e5bc166
parthea pushed a commit that referenced this pull request Nov 26, 2025
@bojeil-google
fix: avoid deleting items while iterating (#772)
0915dc1 
Updates `google.auth.external_account.Credentials#info` to not delete items in the dictionary while iterating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @coveralls @tseaver @googlebot