Replacing _implicit_environ module globals with a container. #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
168d94a to
5a7071d
Compare
Contributor
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
5a7071d to
5a91e30
Compare
Contributor
Author
|
@tseaver Rebased |
Closed
gcloud/datastore/test___init__.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Except for the two redundant assertions I noted, LGTM. |
This is so that a container instance can have lazily loaded properties.
dhermes
force-pushed
the
use-implicit-defaults-container
branch
from
5a91e30 to
b0cdca6
Compare
Contributor
Author
|
Rebased and folded the removal into the original commit. Will merge on Travis. |
dhermes
added a commit
that referenced
this pull request
Feb 19, 2015
Replacing _implicit_environ module globals with a container.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
* docs: Minor formatting PiperOrigin-RevId: 553461544 Source-Link: googleapis/googleapis@347e81d Source-Link: googleapis/googleapis-gen@1177b66 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTE3N2I2NjNkZTUwMDc5ZGJjZmNiYjdlZWJlOTljN2VlMjFjYTA3NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
Source-Link: googleapis/synthtool@352b9d4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
CircleCI machinery now invokes the alternative (Ads) templates for the showcase_alternative_templates_* tests. Includes numerous fixes and additions to the Ads grpc transport, client class, and unit test templates. The showcase system tests now selectively enable async tests via an environment variable. The async client code has not yet been added to the Ads templates, and the corresponding system tests have been disabled for alternative templates.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
In Cloud Datastore ancestor queries are intended to be strong by default (https://cloud.google.com/datastore/docs/concepts/structuring_for_strong_consistency) . In Cloud Firestore in Datastore mode, all queries should be strongly consistent by default (https://cloud.google.com/datastore/docs/upgrade-to-firestore). Fixes #666
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Source-Author: Bu Sun Kim <[email protected]> Source-Date: Mon Jan 11 09:43:06 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 16ec872dd898d7de6e1822badfac32484b5d9031 Source-Link: googleapis/synthtool@16ec872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that a container instance can have lazily loaded properties.
NOTE: Has #663 as a diffbase