Skip to content

Conversation

@alixhami
Copy link
Contributor

@alixhami alixhami commented Nov 6, 2017

No description provided.

@alixhami alixhami added the api: bigquery Issues related to the BigQuery API. label Nov 6, 2017
@alixhami alixhami requested review from dhermes and theacodes November 6, 2017 18:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2017
@theacodes theacodes requested a review from tswast November 6, 2017 18:54
@theacodes
Copy link
Contributor

I'd like @tswast or @jba to take a look from a BigQuery perspective as well.

@jba
Copy link
Contributor

jba commented Nov 6, 2017

LGTM, but I will defer to Tim.

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I wonder if this change makes Client.query_rows() unnecessary?

@alixhami
Copy link
Contributor Author

@tswast If the purpose of Client.query_rows() was just to get query results without calling result(), then it would be unnecessary. Are there other uses for it, or should I remove it in another PR?

@alixhami alixhami merged commit d3999a8 into googleapis:master Nov 13, 2017
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Nov 13, 2017
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
dhermes added a commit that referenced this pull request Nov 13, 2017
This happened because #4350 was sent before #4355 was merged.
@tswast
Copy link
Contributor

tswast commented Nov 13, 2017

Talked in person. Let's remove query_rows in another PR. I can think of no other uses for it.

chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
chemelnucfin pushed a commit to chemelnucfin/google-cloud-python that referenced this pull request Nov 15, 2017
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
@alixhami alixhami deleted the bq-queryjob-iter branch November 16, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants