Skip to content

Allow job_id to be explicitly specified. #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukesneeringer merged 1 commit into from
Aug 9, 2017
Merged

Allow job_id to be explicitly specified. #3779

lukesneeringer merged 1 commit into from
Aug 9, 2017

Conversation

@lukesneeringer
Copy link
Contributor

@lukesneeringer lukesneeringer commented Aug 9, 2017

Unblocks #3742.

@lukesneeringer lukesneeringer self-assigned this Aug 9, 2017
@lukesneeringer lukesneeringer requested a review from tswast August 9, 2017 20:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017
dhermes
dhermes approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tswast
tswast approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lukesneeringer lukesneeringer merged commit a1942ba into googleapis:master Aug 9, 2017
@lukesneeringer lukesneeringer deleted the issue-3742-jobid branch August 9, 2017 20:29
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. api: videointelligence Issues related to the Video Intelligence API API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed api: videointelligence Issues related to the Video Intelligence API API. labels Aug 10, 2017
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@lukesneeringer @landrito
Allow job_id to be explicitly specified. (googleapis#3779)
942a25f
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Allow job_id to be explicitly specified. (googleapis#3779)
74d66cf
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@lukesneeringer @landrito
Allow job_id to be explicitly specified. (googleapis#3779)
92166f9
@lukesneeringer lukesneeringer mentioned this pull request Aug 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

+1 more reviewer

@dhermes dhermes dhermes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukesneeringer @tswast @dhermes @tseaver @googlebot