Skip to content

Add base future package to google.cloud #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 5 commits into from
Jul 17, 2017
Merged

Add base future package to google.cloud #3616

theacodes merged 5 commits into from
Jul 17, 2017

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Jul 17, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2017
@theacodes theacodes mentioned this pull request Jul 17, 2017
Closed
@theacodes
Copy link
Contributor Author

theacodes commented Jul 17, 2017

Towards #3617

dhermes
dhermes reviewed Jul 17, 2017
View reviewed changes
core/google/cloud/_helpers.py
raise ValueError('%r could not be converted to unicode' % (value,))


def _from_any_pb(pb_type, any_pb):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/_helpers.py
any_pb (google.protobuf.any_pb2.Any): the object to be converted.
Returns:
pb_type: An instance of the pb_type message.

This comment was marked as spam.

Sign in to view

core/google/cloud/future/__init__.py
@@ -0,0 +1,21 @@
# Copyright 2017, Google Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/future/base.py Outdated
"""

@abc.abstractmethod
def cancel(self): # pragma: NO COVER

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/future/base.py Outdated

@six.add_metaclass(abc.ABCMeta)
class Future(object):
# pylint: disable=missing-docstring, invalid-name

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/tests/unit/future/test__helpers.py
@@ -0,0 +1,52 @@
# Copyright 2017, Google Inc.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jul 17, 2017

LGTM

@theacodes theacodes merged commit 9c06b35 into googleapis:master Jul 17, 2017
@theacodes theacodes deleted the future branch July 17, 2017 21:27
duggelz
duggelz reviewed Jul 17, 2017
View reviewed changes
core/google/cloud/future/base.py

"""Future interface.
This interface is based on :class:`concurrent.futures.Future`.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Aug 4, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@landrito
Add base future package to google.cloud (googleapis#3616)
4237a80
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add base future package to google.cloud (googleapis#3616)
cf2b636
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Add base future package to google.cloud (googleapis#3616)
a26aa32
parthea pushed a commit that referenced this pull request Nov 24, 2025
Add base future package to google.cloud (#3616)
c211446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

3 more reviewers

@tseaver tseaver tseaver left review comments

@dhermes dhermes dhermes left review comments

@duggelz duggelz duggelz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes @dhermes @tseaver @duggelz @googlebot