-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Flask Helper to Error Reporting #2751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Error Reporting Utilities | ||
| ========================= | ||
|
|
||
| .. automodule:: google.cloud.error_reporting.util | ||
| :members: | ||
| :show-inheritance: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # Copyright 2016 Google Inc. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Utility functions for Stackdriver Error Reporting.""" | ||
|
|
||
| from google.cloud.error_reporting.client import HTTPContext | ||
|
|
||
|
|
||
| def build_flask_context(request): | ||
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong. |
||
| """Builds an HTTP context object from a Flask (Werkzeug) request object. | ||
| This helper method extracts the relevant HTTP context from a Flask request | ||
| object into an object ready to be sent to Error Reporting. | ||
| .. code-block:: python | ||
| >>> @app.errorhandler(HTTPException) | ||
| ... def handle_error(exc): | ||
| ... client.report_exception( | ||
| ... http_context=build_flask_context(request)) | ||
| ... # rest of error response code here | ||
| :type request: :class:`werkzeug.wrappers.request` | ||
| :param request: The Flask request object to convert. | ||
| :rtype: :class:`~google.cloud.error_reporting.client.HTTPContext` | ||
| :returns: An HTTPContext object ready to be sent to the Stackdriver Error | ||
| Reporting API. | ||
| """ | ||
| return HTTPContext(url=request.url, method=request.method, | ||
| user_agent=request.user_agent.string, | ||
| referrer=request.referrer, | ||
| remote_ip=request.remote_addr) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Copyright 2016 Google Inc. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import unittest | ||
|
|
||
|
|
||
| class Test_build_flask_context(unittest.TestCase): | ||
|
|
||
| def _call_fut(self, request): | ||
| from google.cloud.error_reporting.util import build_flask_context | ||
This comment was marked as spam.
Sorry, something went wrong. |
||
| return build_flask_context(request) | ||
|
|
||
| def test_flask_helper(self): | ||
| import mock | ||
|
|
||
| user_agent = mock.Mock(string='Google Cloud Unit Tests Agent') | ||
| request = _Request('http://google.com', 'GET', | ||
| user_agent, | ||
| 'http://gmail.com', | ||
| '127.0.0.1') | ||
|
|
||
| context = self._call_fut(request) | ||
| self.assertEqual(request.url, context.url) | ||
| self.assertEqual(request.method, context.method) | ||
| self.assertEqual(request.user_agent.string, context.userAgent) | ||
| self.assertEqual(request.referrer, context.referrer) | ||
| self.assertEqual(request.remote_addr, context.remoteIp) | ||
|
|
||
|
|
||
| class _Request(object): | ||
|
|
||
| def __init__(self, url, method, user_agent, referrer, remote_addr): | ||
| self.url = url | ||
| self.method = method | ||
| self.user_agent = user_agent | ||
| self.referrer = referrer | ||
| self.remote_addr = remote_addr | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.