Skip to content

Allow positional arguments tox -e system-tests. #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Sep 12, 2016
Merged

Allow positional arguments tox -e system-tests. #2304

dhermes merged 1 commit into from
Sep 12, 2016

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 12, 2016

Fixes #2300.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2016
tseaver
tseaver reviewed Sep 12, 2016
View reviewed changes
system_tests/attempt_system_tests.py
if args.packages is ALL_MODULES:
result = list(MODULES)
if sys.version_info[:2] != (2, 7):
result.remove(BIGTABLE_API)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2016

I'm 👍 on the feature overall.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 12, 2016

@tseaver How do you feel about merging this and handling the gRPC dep stuff (including the bigtable system test being left out) in a standalone PR?

@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2016

How do you feel about merging this and handling the gRPC dep stuff (including the bigtable system test being left out) in a standalone PR?

SGTM

@dhermes dhermes merged commit 1537d4a into googleapis:master Sep 12, 2016
@dhermes dhermes deleted the fix-2300 branch September 12, 2016 22:18
@dhermes dhermes mentioned this pull request Sep 12, 2016
Merged
@tseaver tseaver mentioned this pull request Sep 14, 2016
Closed
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gkevinzheng
build: Use Ubuntu 22.04 for tests that require the use of Python 3.7 (#…
def8ec5 
…2304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes @tseaver @daspecster @googlebot