Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 8, 2016

See: #2265 (comment)

Note that the added tests uncovered a bug in unmarshalling RECORD-type fields with non-string subfields.

/cc @thejens

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. testing api: bigquery Issues related to the BigQuery API. labels Sep 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2016
@dhermes
Copy link
Contributor

dhermes commented Sep 8, 2016

LGTM

@tseaver tseaver merged commit a8338fd into googleapis:master Sep 8, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
@tseaver tseaver deleted the 2265-bigquery-test-json-helpers-directly branch September 20, 2016 18:48
parthea added a commit that referenced this pull request Nov 24, 2025
… service YAML (#2272)

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Victor Chudnovsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants