Skip to content

Retry on 500 from 'descriptor.{create,delete}'. #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 1 commit into from
Aug 25, 2016
Merged

Retry on 500 from 'descriptor.{create,delete}'. #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions system_tests/monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

from gcloud import _helpers
from gcloud.environment_vars import TESTS_PROJECT
from gcloud.exceptions import InternalServerError
from gcloud.exceptions import NotFound
from gcloud.exceptions import ServiceUnavailable
from gcloud import monitoring
Expand All @@ -24,6 +25,8 @@
from system_test_utils import unique_resource_id

retry_404 = RetryErrors(NotFound)
retry_404_500 = RetryErrors((NotFound, InternalServerError))
retry_500 = RetryErrors(InternalServerError)
retry_503 = RetryErrors(ServiceUnavailable)


Expand Down Expand Up @@ -176,8 +179,8 @@ def test_create_and_delete_metric_descriptor(self):
description=DESCRIPTION,
)

descriptor.create()
retry_404(descriptor.delete)()
retry_500(descriptor.create())
retry_404_500(descriptor.delete)()

This comment was marked as spam.

Sign in to view


with self.assertRaises(NotFound):
descriptor.delete()
Expand Down