Wait even longer for orphan's topic to be None. #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
@daspecster, @dhermes I plan to merge this one-digit diff as soon as Travis is green, trying to get the build passing w/ both system test runs. |
Contributor
|
Instead of 8 tries would it work better to increase the wait time/delay? I'm just thinking of quotas but we probably have a really high quota for this. |
Contributor
|
Either way LGTM if it works for master! 🎉 |
Contributor
Author
|
@daspecster We aren't seeing quota-based failures: it just takes longer than expected for the deletion of the topic to show up when reloading the orphaned subscription. |
Contributor
|
LGTM as well |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #2080.