Update the helper _datetime_to_rfc3339 to handle time zones. #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper function _format_timestamp in gcloud.monitoring.query is superseded by this updated helper function.
googlebot
added
the
cla: yes
gcloud/_helpers.py
Outdated
| :rtype: str | ||
| :returns: The string representing the datetime stamp. | ||
| """ | ||
| if not(ignore_zone or value.tzinfo is None): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Mostly LGTM other than the nit about the Thanks a lot for doing this! |
Contributor
|
LGTM once Travis passes |
This was referenced Aug 3, 2016
Closed
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper function _format_timestamp in gcloud.monitoring.query is
superseded by this updated helper function.