Skip to content

Pylint 1.6.3 compatibility #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 2 commits into from
Jul 18, 2016
Merged

Pylint 1.6.3 compatibility #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b602d18
pylint 1.6.3 complains about not calling .
tseaver Jul 18, 2016
cdf2e37
Bump minimum pylint version to 1.6.3.
tseaver Jul 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gcloud/logging/test__gax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,8 @@ class _DummyException(AbortionError):
code = status_code

def __init__(self):
pass
super(_DummyException, self).__init__(
None, None, self.code, None)

return _DummyException()

Expand Down
3 changes: 2 additions & 1 deletion gcloud/pubsub/test__gax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,8 @@ class _DummyException(AbortionError):
code = status_code

def __init__(self):
pass
super(_DummyException, self).__init__(
None, None, self.code, None)

return _DummyException()

Expand Down
4 changes: 0 additions & 4 deletions scripts/run_pylint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@
]
IGNORED_FILES = [
os.path.join('docs', 'conf.py'),
# Both these files cause pylint 1.6 to barf. See:
# https://github.com/PyCQA/pylint/issues/998
os.path.join('gcloud', 'bigtable', 'happybase', 'connection.py'),
os.path.join('gcloud', 'streaming', 'http_wrapper.py'),
'setup.py',
]
SCRIPTS_DIR = os.path.abspath(os.path.dirname(__file__))
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,12 @@ commands =
python {toxinidir}/scripts/run_pylint.py
deps =
pep8
pylint
pylint >= 1.6.3
unittest2
psutil
Sphinx
setenv =
PYTHONPATH =
passenv = {[testenv:system-tests]passenv}

[testenv:system-tests]
Expand Down