Attempt to fix windows path crash #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
gahhh...lint |
daspecster
force-pushed
the
fix-default-project-id-on-windows
branch
2 times, most recently
from
709f2a5 to
100ac64
Compare
Contributor
|
@daspecster I just merged #1974 to |
daspecster
force-pushed
the
fix-default-project-id-on-windows
branch
from
100ac64 to
bbfefee
Compare
Contributor
|
LGTM |
Contributor
|
Ugh, still blows up trying to install |
Contributor
Author
|
yeah I noticed that... |
This was referenced Aug 3, 2016
Closed
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tseaver not sure how I feel about the
NO COVER's. The only other option I could think of was skipping tests on windows.Appveyor: https://ci.appveyor.com/project/daspecster/gcloud-python-utjkc
LMKWYT