-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Install gRPC et al for testing except py26/lint/docs-rtd #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm going to go ahead with 0.17.0 without this one. |
|
Changes look mostly good. Failures caused by what? |
|
Ugh, no idea -- I can't reproduce on my Ubuntu Trusty machine here. "Two hard things in computer science: caching, naming things, and off-by-one errors." |
|
@tseaver it did the same thing to me on OSX, someone reported it here and I opened an issue on grpc. I believe grpc needs to do a release before this works again. How I reproduce the issue. I made a virtualenv with py34. mkvirtualenv -p /usr/local/bin/python3.4 test-multi
python setup.py install
pip install tox
tox -e py34Key points from the log output that it mentions in the error... |
|
@tseaver, should we just close this for now and hope that future |
I think we want to be where this PR is (the rationalize |
- Install 'grpcio' and related deps by default, and omit adding '_testing' to PYTHONPATH. - For Python 2.6, and lint, RTD, suppress installing gRPC-related deps, and add '_testing' to PYTHONPATH.
Also, pin GAX/GRPC libraries to avoid future breaking changes.
|
@dhermes, @daspecster I rebased to fix conflicts, and also updated the version pins for the gRPC-related dependencies to reflect today's grpcio-1.0rc1 release, as well as comments from @bjwatson on potential future breaking changes for the GAX libraries. |
|
Woohoo! Travis is happy, at least for the PR. |
| {[testing]deps} | ||
| {[grpc]deps} | ||
|
|
||
| [testenv:py26] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes, @daspecster any remaining issues? |
| python2.7 | ||
| [docs] | ||
| deps = | ||
| {[testenv]deps} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
| 'gax-google-pubsub-v1 >= 0.7.12, < 0.8dev', | ||
| 'grpc-google-pubsub-v1 >= 0.7.12, < 0.8dev', | ||
| 'gax-google-logging-v2 >= 0.7.12, < 0.8dev', | ||
| 'grpc-google-logging-v2 >= 0.7.12, < 0.8dev', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rationalize tox vs. gRPC:
grpcioand related deps by default, and omit adding_testingto PYTHONPATH._testingto PYTHONPATH.Bump minimum version for
grpcioto 0.15.0.Fix up Py3k failures with
grpcioinstalled.@daspecster, @dhermes Maybe this should land before 0.17.0?