Skip to content

Return self in Bigtable client __enter__. #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 1 commit into from
May 20, 2016
Merged

Return self in Bigtable client __enter__. #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gcloud/bigtable/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ def start(self):
def __enter__(self):
"""Starts the client as a context manager."""
self.start()
return self

def stop(self):
"""Closes all the open gRPC clients."""
Expand Down
4 changes: 4 additions & 0 deletions gcloud/bigtable/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ def test_context_manager(self):
self.assertTrue(client.is_started())
self.assertFalse(client.is_started())

def test_context_manager_as_keyword(self):
with self._context_manager_helper() as client:
self.assertIsNotNone(client)

def test_context_manager_with_exception(self):
client = self._context_manager_helper()
self.assertFalse(client.is_started())
Expand Down