Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 15, 2016

Similar to #1388. The API accepts integers and then encodes them as bytes when stored in the table.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Jan 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2016

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the bigtable-increment-cell-value branch 2 times, most recently from 724fd9d to ac6f9ae Compare January 15, 2016 17:10
Similar to googleapis#1388. The API accepts integers and then encodes them
as bytes when stored in the table.
@dhermes dhermes force-pushed the bigtable-increment-cell-value branch from ac6f9ae to 51743b3 Compare January 15, 2016 17:13
@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2016

@tseaver PTAL I rebased after #1387 and #1388 went in.

@tseaver
Copy link
Contributor

tseaver commented Jan 15, 2016

LGTM (in spite of the awkward diff).

@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2016

Sorry for the awkward diff. The 1st and 2nd commit aren't too bad, but when put together they are. I did the 2nd commit because I messed up the order when I rebased #1387.

dhermes added a commit that referenced this pull request Jan 15, 2016
Adding Bigtable Row.increment_cell_value.
@dhermes dhermes merged commit ffe5869 into googleapis:master Jan 15, 2016
@dhermes dhermes deleted the bigtable-increment-cell-value branch January 15, 2016 18:09
parthea added a commit that referenced this pull request Nov 24, 2025
* fix: Fix required fields test for REST transport

This fixes the assumption that query param fields can be only primitives. They also can be enums and special proto objects which serialize to string in json mapping: FieldMask, Timestam, Duration.

The tests will follow in a form of integration tests once grpc+rest transport is enabled in googleapis

* update python version in noxfile template to match CI

* regenerate goldens

* remove assumption that query param fields can be only primitives

* update black version in templated noxfile to fix CI

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* fix: update urllib3 to >= 2.0.5

* update

* update sys test cred
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants