Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 15, 2016

Currently, the GOOGLE_APPLICATION_CREDENTIALS is used and an access token is minted even though requests to the emulator require no authentication.

Currently, the GOOGLE_APPLICATION_CREDENTIALS is used and an access
token is minted even though requests to the emulator require no
authentication.
@dhermes dhermes added api: datastore Issues related to the Datastore API. testing labels Jan 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2016

By allowing the default behavior to occur, an authorized http instance tries to [get a new] access token even if it doesn't need one.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 15, 2016

@pcostell Is it intended that the emulator doesn't check the value of the Authorization header (or even if the header has been sent)?

@tseaver
Copy link
Contributor

tseaver commented Jan 15, 2016

LGTM

dhermes added a commit that referenced this pull request Jan 15, 2016
Allowing datastore system test to run on emulator with no connection.
@dhermes dhermes merged commit 0b602ea into googleapis:master Jan 15, 2016
@dhermes dhermes deleted the ds-emulator-no-internet branch January 15, 2016 16:33
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants