Renaming path_element->path in Key. #1360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
added
api: datastore
googlebot
added
the
cla: yes
dhermes
force-pushed
the
rename-path-element-1288
branch
from
20931bf to
49fce26
Compare
dhermes
force-pushed
the
rename-path-element-1288
branch
from
49fce26 to
771e710
Compare
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…1360) These changes allow running the generated python gapic unit tests on the fly by bazel right after generation in our CI. As a result of this change some of the issues with the generated code became immediatelly visible (because now we ran the generated tests) and will be addressed separately in these issues: googleapis/gapic-generator-python#1358 googleapis/gapic-generator-python#1359 The tests can be now added in BUILD.bazel files as follows: ```bzl py_test( name = "credentials_py_gapic_test", srcs = [ "credentials_py_gapic_pytest.py", "credentials_py_gapic_test.py", ], legacy_create_init = False, deps = [ ":credentials_py_gapic", ], ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't be merged until
v1beta3is released.As with #1359, relies on #1329 being merged, I just used
_has_fieldeven though it hadn't been implemented yet since I knew the tests would fail anyway.