Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 6, 2016

Somewhat inspired by #1069 (or at least the branch referenced there, which I recently deleted).

Also follows on #1345.

@dhermes dhermes added api: datastore Issues related to the Datastore API. docs labels Jan 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes dhermes force-pushed the datastore-docs-cleanup branch from 6067b8d to 8058d96 Compare January 7, 2016 21:22
@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

@tseaver Made the changes and rebased

@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

LGTM

Note that this is another case of squash-defeats-re-review.

dhermes added a commit that referenced this pull request Jan 7, 2016
@dhermes dhermes merged commit 02c645f into googleapis:master Jan 7, 2016
@dhermes dhermes deleted the datastore-docs-cleanup branch January 7, 2016 22:55
@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

Ack on the squashing. Will change behavior (remind me if I forget). (Makes me miss Google's code review tool.)

@tseaver
Copy link
Contributor

tseaver commented Jan 7, 2016

I've seen a Github feature request somewhere for a "Merge w/ squash" button.

@dhermes
Copy link
Contributor Author

dhermes commented Jan 7, 2016

👍 I like it

parthea added a commit that referenced this pull request Nov 24, 2025
* ci: fix ci

* remove .bazelversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants