Skip to content

Conversation

@theacodes
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2015
README.rst Outdated

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Sep 25, 2015

LGTM (LMK if you don't have merge privileges)

@theacodes
Copy link
Contributor Author

Thanks. I do not have merge powers.

On Fri, Sep 25, 2015, 8:41 AM Danny Hermes [email protected] wrote:

LGTM (LMK if you don't have merge privileges)


Reply to this email directly or view it on GitHub
#1155 (comment)
.

dhermes added a commit that referenced this pull request Sep 25, 2015
Update README.rst to link to Python Getting Started sample and tutorial.
@dhermes dhermes merged commit 2f1d0c0 into googleapis:master Sep 25, 2015
parthea added a commit that referenced this pull request Nov 24, 2025
I've confirmed that the unit tests in python-compute are still passing with this change.

Fixes #1154
parthea pushed a commit that referenced this pull request Nov 24, 2025
…uping (#1155)

* fix: fix grouped labels using custom functions

If we have a labeled custom function that we are grouping by, and the
function does not support the `default` dialect, we can not compile our
query.

* Update tests/unit/test_compiler.py

---------

Co-authored-by: Tim Sweña (Swast) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants