Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 24, 2015

@dhermes dhermes added the docs label Aug 24, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

Notice I also changed the relative #google-cloud-storage links to absolute ones. This is because they don't get rendered on https://pypi.python.org/pypi/gcloud when they are relative (and having relative "CONTRIBUTING" actually complete broke the PyPI RST parser before).

Maybe we should add something to our CONTRIBUTING doc warning about using non-absolute links in the README?

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2015

LGTM.

A note in CONTRIBUTING.rst might help, if only there were impetus to read it. :)

dhermes added a commit that referenced this pull request Aug 24, 2015
Adding BigQuery and Pub/Sub to README.
@dhermes dhermes merged commit 34d652e into googleapis:master Aug 24, 2015
@dhermes dhermes deleted the fix-1076 branch August 24, 2015 20:13
@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

You don't think the doc is worthwhile?

@tseaver
Copy link
Contributor

tseaver commented Aug 24, 2015

I just meant that you and I are the ones most likely to forget, and least likely of all to look at CONTRIBUTING.rst. Go ahead and add the note.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 24, 2015

Ah gotcher.

parthea pushed a commit that referenced this pull request Nov 24, 2025
* Revert "test: add tests for autogen-snippets option (#1055)"

This reverts commit 185ecc7536db8309e6d2f03f9a66c36db18b1945.

* Revert "feat: generate code snippets by default (#1044)"

This reverts commit e46f443dbeffe16b63f97668801b06189769e972.
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README.rst page doesn't mention the pub/sub client or bq

3 participants