Skip to content

Refactor Storage read and write streams #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
callmehiphop merged 3 commits into from
Aug 27, 2015
Merged

Refactor Storage read and write streams #824

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f306dcf
storage: clean read-streams
stephenplusplus Aug 26, 2015
cd9f7ba
storage: clean write streams
stephenplusplus Aug 26, 2015
0602fd4
throw if trying to use validation with a range request
stephenplusplus Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/storage/bucket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ Bucket.prototype.upload = function(localPath, options, callback) {
.on('error', function(err) {
callback(err);
})
.on('complete', function() {
.on('finish', function() {
callback(null, newFile);
});
}
Expand Down
Loading