Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

Our deleteFiles and makeAllFilesPublicPrivate_ methods behave similarly. First, get files, then (delete || make them private || make them private). We were previously looking for a nextQuery and handling pagination manually when getting files. That's no longer necessary since we incorporated streamRouter.

@stephenplusplus stephenplusplus added the api: storage Issues related to the Cloud Storage API. label Jul 31, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2015
@stephenplusplus stephenplusplus force-pushed the spp--storage-use-streamrouter branch from b348510 to 3a625e0 Compare July 31, 2015 14:03
stephenplusplus added a commit that referenced this pull request Jul 31, 2015
…outer

storage: update code that now uses streamrouter
@stephenplusplus stephenplusplus merged commit b18e5e2 into googleapis:master Jul 31, 2015
sofisl pushed a commit that referenced this pull request Jan 17, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://togithub.com/uuidjs/uuid) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/7.0.3/8.0.0) |
| [uuid](https://togithub.com/uuidjs/uuid) | devDependencies | major | [`^3.4.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/3.4.0/8.0.0) |

---

### Release Notes

<details>
<summary>uuidjs/uuid</summary>

### [`v8.0.0`](https://togithub.com/uuidjs/uuid/blob/master/CHANGELOG.md#&#8203;800-httpsgithubcomuuidjsuuidcomparev703v800-2020-04-29)

[Compare Source](https://togithub.com/uuidjs/uuid/compare/v7.0.3...v8.0.0)

##### ⚠ BREAKING CHANGES

-   For native ECMAScript Module (ESM) usage in Node.js only named exports are exposed, there is no more default export.

    ```diff
    -import uuid from 'uuid';
    -console.log(uuid.v4()); // -> 'cd6c3b08-0adc-4f4b-a6ef-36087a1c9869'
    +import { v4 as uuidv4 } from 'uuid';
    +uuidv4(); // ⇨ '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d'
    ```

-   Deep requiring specific algorithms of this library like `require('uuid/v4')`, which has been deprecated in `uuid@7`, is no longer supported.

    Instead use the named exports that this module exports.

    For ECMAScript Modules (ESM):

    ```diff
    -import uuidv4 from 'uuid/v4';
    +import { v4 as uuidv4 } from 'uuid';
    uuidv4();
    ```

    For CommonJS:

    ```diff
    -const uuidv4 = require('uuid/v4');
    +const { v4: uuidv4 } = require('uuid');
    uuidv4();
    ```

##### Features

-   native Node.js ES Modules (wrapper approach) ([#&#8203;423](https://togithub.com/uuidjs/uuid/issues/423)) ([2d9f590](https://togithub.com/uuidjs/uuid/commit/2d9f590ad9701d692625c07ed62f0a0f91227991)), closes [#&#8203;245](https://togithub.com/uuidjs/uuid/issues/245) [#&#8203;419](https://togithub.com/uuidjs/uuid/issues/419) [#&#8203;342](https://togithub.com/uuidjs/uuid/issues/342)
-   remove deep requires ([#&#8203;426](https://togithub.com/uuidjs/uuid/issues/426)) ([daf72b8](https://togithub.com/uuidjs/uuid/commit/daf72b84ceb20272a81bb5fbddb05dd95922cbba))

##### Bug Fixes

-   add CommonJS syntax example to README quickstart section ([#&#8203;417](https://togithub.com/uuidjs/uuid/issues/417)) ([e0ec840](https://togithub.com/uuidjs/uuid/commit/e0ec8402c7ad44b7ef0453036c612f5db513fda0))

##### [7.0.3](https://togithub.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) (2020-03-31)

##### Bug Fixes

-   make deep require deprecation warning work in browsers ([#&#8203;409](https://togithub.com/uuidjs/uuid/issues/409)) ([4b71107](https://togithub.com/uuidjs/uuid/commit/4b71107d8c0d2ef56861ede6403fc9dc35a1e6bf)), closes [#&#8203;408](https://togithub.com/uuidjs/uuid/issues/408)

##### [7.0.2](https://togithub.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) (2020-03-04)

##### Bug Fixes

-   make access to msCrypto consistent ([#&#8203;393](https://togithub.com/uuidjs/uuid/issues/393)) ([8bf2a20](https://togithub.com/uuidjs/uuid/commit/8bf2a20f3565df743da7215eebdbada9d2df118c))
-   simplify link in deprecation warning ([#&#8203;391](https://togithub.com/uuidjs/uuid/issues/391)) ([bb2c8e4](https://togithub.com/uuidjs/uuid/commit/bb2c8e4e9f4c5f9c1eaaf3ea59710c633cd90cb7))
-   update links to match content in readme ([#&#8203;386](https://togithub.com/uuidjs/uuid/issues/386)) ([44f2f86](https://togithub.com/uuidjs/uuid/commit/44f2f86e9d2bbf14ee5f0f00f72a3db1292666d4))

##### [7.0.1](https://togithub.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) (2020-02-25)

##### Bug Fixes

-   clean up esm builds for node and browser ([#&#8203;383](https://togithub.com/uuidjs/uuid/issues/383)) ([59e6a49](https://togithub.com/uuidjs/uuid/commit/59e6a49e7ce7b3e8fb0f3ee52b9daae72af467dc))
-   provide browser versions independent from module system ([#&#8203;380](https://togithub.com/uuidjs/uuid/issues/380)) ([4344a22](https://togithub.com/uuidjs/uuid/commit/4344a22e7aed33be8627eeaaf05360f256a21753)), closes [#&#8203;378](https://togithub.com/uuidjs/uuid/issues/378)

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-vision).
gcf-owl-bot bot added a commit that referenced this pull request Mar 16, 2023
Source-Link: googleapis/googleapis@c2016e5

Source-Link: googleapis/googleapis-gen@0885fd7
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4ODVmZDdhZThhODA1YTM3Nzk3NGVkZmJhNjBhYjdjOTMyN2Y3NWEifQ==
sofisl added a commit that referenced this pull request Mar 20, 2023
…#4091)

* feat: Update Compute Engine API to revision 20230307 (#770)

Source-Link: googleapis/googleapis@c2016e5

Source-Link: googleapis/googleapis-gen@0885fd7
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4ODVmZDdhZThhODA1YTM3Nzk3NGVkZmJhNjBhYjdjOTMyN2Y3NWEifQ==

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* build: fix dataform publishing(#4099)

Release-As: 0.4.1

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <[email protected]>
@release-please release-please bot mentioned this pull request Mar 20, 2023
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
* chore: use gts v2 (#757)

googleapis/gax-nodejs@247aeb7
commit 247aeb7668c4787596aeaea22f727549bcdf068d
Author: Alexander Fenster <[email protected]>
Date:   Thu Mar 26 13:04:10 2020 -0700

    chore: use gts v2 (#757)

    * chore: use gts v2

    * chore: ahhhhh thaaaats why

    * chore: do not run on node8

    * fix: new gts rules

* build: use TypeScript ^3.8.3, set lib to es2018 (#760)

googleapis/gax-nodejs@41c73f8
commit 41c73f886e0106d0d7b1b851b4823990495d8fc7
Author: Alexander Fenster <[email protected]>
Date:   Thu Mar 26 13:34:19 2020 -0700

    build: use TypeScript ^3.8.3, set lib to es2018 (#760)

    * build: use TypeScript ^3.8.3, set lib to es2018

    * fix: better typing

* chore!: require Node.js v10+ (#759)

googleapis/gax-nodejs@23ec7f6
commit 23ec7f69c3813f6d06ea8b2a473d072337e1b499
Author: Alexander Fenster <[email protected]>
Date:   Thu Mar 26 14:07:14 2020 -0700

    chore!: require Node.js v10+ (#759)

    BREAKING CHANGE: use Node.js v10+

* chore(deps): update dependency @types/rimraf to v3 (#751)

googleapis/gax-nodejs@2f1b6ae
commit 2f1b6aedbbd620a1e9872b858e58264056344571
Author: WhiteSource Renovate <[email protected]>
Date:   Thu Mar 26 22:27:20 2020 +0100

    chore(deps): update dependency @types/rimraf to v3 (#751)

    Co-authored-by: Alexander Fenster <[email protected]>

* chore: release 2.0.0 (#738)

googleapis/gax-nodejs@1c11c80
commit 1c11c8015f93a6a711a9f113105d027095a3d90c
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Thu Mar 26 22:32:20 2020 +0000

    chore: release 2.0.0 (#738)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [2.0.0](https://www.github.com/googleapis/gax-nodejs/compare/v1.14.2...v2.0.0) (2020-03-26)

    ### ⚠ BREAKING CHANGES

    * use Node.js v10+
    * throw for versions of Node.js older than v10.0.0 (#748)
    * stop accepting Promise constructor (#737)

    ### Features

    * export bundle descriptor in descriptors interface ([#744](https://www.github.com/googleapis/gax-nodejs/issues/744)) ([b1eccf9](https://www.github.com/googleapis/gax-nodejs/commit/b1eccf96c439d67376d249a54c9d22ffe7ff1839))
    * export ServiceError from @grpc/grpc-js ([#754](https://www.github.com/googleapis/gax-nodejs/issues/754)) ([24a4d60](https://www.github.com/googleapis/gax-nodejs/commit/24a4d600738a9597e9a87d6705eaed3dc2285e3b))
    * stop accepting Promise constructor ([#737](https://www.github.com/googleapis/gax-nodejs/issues/737)) ([816bf9b](https://www.github.com/googleapis/gax-nodejs/commit/816bf9b283217208debd979e893a6daf29f1f739))
    * support async iterator for paging method ([#708](https://www.github.com/googleapis/gax-nodejs/issues/708)) ([3ac5afb](https://www.github.com/googleapis/gax-nodejs/commit/3ac5afb3b1b1b22798f15ee07395f3ca765383b4))
    * throw for versions of Node.js older than v10.0.0 ([#748](https://www.github.com/googleapis/gax-nodejs/issues/748)) ([511fc23](https://www.github.com/googleapis/gax-nodejs/commit/511fc233bd66d537c24743ef460ee8c609cd551f))

    ### Bug Fixes

    * **deps:** update dependency @grpc/grpc-js to ^0.7.0 ([#736](https://www.github.com/googleapis/gax-nodejs/issues/736)) ([01c428c](https://www.github.com/googleapis/gax-nodejs/commit/01c428cb1240320b92778abf1297a5ff72346fd9))
    * **deps:** use @grpc/grpc-js v0.7.2 ([#735](https://www.github.com/googleapis/gax-nodejs/issues/735)) ([836e81b](https://www.github.com/googleapis/gax-nodejs/commit/836e81b64f84d8c118e6aea0580f0645658a8490))
    * **deps:** use protobuf.js v6.8.9 ([#743](https://www.github.com/googleapis/gax-nodejs/issues/743)) ([fab91ce](https://www.github.com/googleapis/gax-nodejs/commit/fab91ce334d76212d7e31b5478331339c5acad76))
    * allow passing numbers as path template parameters ([#756](https://www.github.com/googleapis/gax-nodejs/issues/756)) ([c466d3d](https://www.github.com/googleapis/gax-nodejs/commit/c466d3dc68c8f9050d3ae69dcedd708e3509ae17))

    ### Miscellaneous Chores

    * require Node.js v10+ ([#759](https://www.github.com/googleapis/gax-nodejs/issues/759)) ([23ec7f6](https://www.github.com/googleapis/gax-nodejs/commit/23ec7f69c3813f6d06ea8b2a473d072337e1b499))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* fix(deps): update dependency google-auth-library to v6 (#763)

googleapis/gax-nodejs@72114db
commit 72114db1b15af3034c51a784e3fc619e2ee281e5
Author: WhiteSource Renovate <[email protected]>
Date:   Sat Mar 28 04:08:38 2020 +0100

    fix(deps): update dependency google-auth-library to v6 (#763)

* fix: make async iteration work for gRPC-fallback; refactor the code (#765)

googleapis/gax-nodejs@944c06b
commit 944c06b4225c4dd5cdcf08e4ca2497cfe3a69cde
Author: Alexander Fenster <[email protected]>
Date:   Fri Mar 27 22:19:15 2020 -0700

    fix: make async iteration work for gRPC-fallback; refactor the code (#765)

* chore: release 2.0.1 (#766)

googleapis/gax-nodejs@3ce902d
commit 3ce902d94f6112853df4098b50ca46bb228a69b5
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Sat Mar 28 05:30:07 2020 +0000

    chore: release 2.0.1 (#766)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ### [2.0.1](https://www.github.com/googleapis/gax-nodejs/compare/v2.0.0...v2.0.1) (2020-03-28)

    ### Bug Fixes

    * **deps:** update dependency google-auth-library to v6 ([#763](https://www.github.com/googleapis/gax-nodejs/issues/763)) ([72114db](https://www.github.com/googleapis/gax-nodejs/commit/72114db1b15af3034c51a784e3fc619e2ee281e5))
    * make async iteration work for gRPC-fallback; refactor the code ([#765](https://www.github.com/googleapis/gax-nodejs/issues/765)) ([944c06b](https://www.github.com/googleapis/gax-nodejs/commit/944c06b4225c4dd5cdcf08e4ca2497cfe3a69cde))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).

* build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#770)

googleapis/gax-nodejs@a1e4a3f
commit a1e4a3fd9877b1370869a919e1165ea69410f201
Author: Benjamin E. Coe <[email protected]>
Date:   Tue Mar 31 18:34:30 2020 -0700

    build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#770)

* fix: do not run node 8 CI (#456)

googleapis/synthtool@1b4cc80
commit 1b4cc80a7aaf164f6241937dd87f3bd1f4149e0c
Author: Alexander Fenster <[email protected]>
Date:   Wed Mar 25 08:01:31 2020 -0700

    fix: do not run node 8 CI (#456)

* fix: update template files for Node.js libraries (#463)

googleapis/synthtool@9982024
commit 99820243d348191bc9c634f2b48ddf65096285ed
Author: Alexander Fenster <[email protected]>
Date:   Tue Mar 31 11:56:27 2020 -0700

    fix: update template files for Node.js libraries (#463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants