chore: migrate code from googleapis/nodejs-error-reporting #7019
+9,719
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The timeout used for waiting for the API to report an error event has been increased. * The system tests only poll for error events for a specific service and version. * The page size has been increased when requesting reported errors. * Increase polling timeout to avoid using the API too much to hit quota exceeded errors. * Error items are not deleted after the test. This is needed to avoid conflicting with concurrent runs of the system test because it is not possible to delete error items only associated with a particular test.
* build: add Kokoro configs for autorelease * build: add Kokoro configs for autorelease * chore: remove CircleCI config
This is being done to address the system test flakiness by having the most recently created error item listed first in the list of error items retrieved from the error reporting service.
The test config was only running tests that were in directories within the `test/unit` directory. Now those tests as well as test files in the `test/unit` directory itself are run.
This change is made to address the error: ``` Error: Quota exceeded for quota metric 'clouderrorreporting.googleapis.com/manage_error_events_data_requests' and limit 'ManageErrorEventsDataRequestsPerMinutePerUser' of service 'clouderrorreporting.googleapis.com' ```
Adds the `reportMode` configuration option. The `ignoreEnvironmentCheck` configuration option is now deprecated, and the `reportMode` option should be used instead. In particular, the `reportMode` can have one of three values: * 'production' (default) - Only report errors if NODE_ENV is set to "production".: * 'always' - Always report errors regardless of the value of NODE_ENV. * 'never' - Never report errors regardless of the value of NODE_ENV. Fixes #127
Automerge by dpebot
request.url can be a url.URL object. Fixes: googleapis/nodejs-error-reporting#196
* fix: do not try and authenticate when error reporting is disabled * remove extra commit * lint * Update test to check auth call * fix lint * unnock
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* docs: remove samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* fix: Add a partner team as approvers for PRs Adding @googleapis/api-logging-partners to contain more people who can approve PRs * Update sync-repo-settings.yaml * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update sync-repo-settings.yaml * Update CODEOWNERS * Update owlbot.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: losalex <[email protected]>
* docs: fix node release schedule link Co-authored-by: Jeffrey Rennie <[email protected]> Source-Link: googleapis/synthtool@1a24315 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore!: upgrade to Node 14 * chore: skip system tests that are failing --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]>
…s directly from the library (#724) * chore: call non-hermetic functions since we're installing node_modules directly from the library * chore: call non-hermetic functions since we're installing node_modules directly from the library Source-Link: googleapis/synthtool@4c4063f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:8b6a07a38d1583d96b6e251ba208bd4ef0bc2a0cc37471ffc518841651d15bd6 * Update owlbot.py --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <[email protected]>
* fix: Add `system-test/fixtures` to `.eslintignore` * refactor: Use `**` Source-Link: googleapis/synthtool@b7858ba Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:abc68a9bbf4fa808b25fa16d3b11141059dc757dbc34f024744bba36c200b40f Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(docs): Update .readme-partials.yaml Removed out-dated code samples and pointed the README towards the https://cloud.google.com/error-reporting/docs/setup/nodejs documentation instead. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* test: Coerce type to fix broken tests due to depend * Try downgrading the dependency * adjust dev dependency * Upgrade dependency again * upgrade compodoc one last time * Add comment * another comment * Remove comment
* chore: use pack-n-play instead of post-install
* chore: remove api-logging team from CODEOWNERS and blunderbuss * chore: remove api-logging-partners and use yoshi-nodejs as owner * chore: remove remaining api-logging teams from configuration files
GautamSharda
changed the title
…pis/google-cloud-node into nodejs-error-reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕