docs: var storage -> var gcs; #664

stephenplusplus · 2015-06-17T13:51:40Z

Fixes #619

Docs: http://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/

ryanseys · 2015-06-17T14:04:38Z

Will review
On Jun 17, 2015 6:51 AM, "Stephen Sawchuk" [email protected] wrote:

Fixes #619 #619

You can view, comment on, or merge this pull request online at:

#664
Commit Summary

docs: var storage -> var gcs;

File Changes

M docs/site/home.html
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-0
(8)

M lib/bigquery/table.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-1
(18)

M lib/index.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-2
(6)

M lib/storage/acl.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-3
(20)

M lib/storage/bucket.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-4
(12)

M lib/storage/file.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-5
(16)

M lib/storage/index.js
https://github.com/GoogleCloudPlatform/gcloud-node/pull/664/files#diff-6
(36)

Patch Links:

https://github.com/GoogleCloudPlatform/gcloud-node/pull/664.patch

https://github.com/GoogleCloudPlatform/gcloud-node/pull/664.diff

—
Reply to this email directly or view it on GitHub
#664.

jgeewax · 2015-06-17T14:49:15Z

LGTM

ryanseys · 2015-06-17T14:55:23Z

You missed a few, one in the README and some throughout the tests.

/Users/ryanseys/gcloud-node/README.md:
  175  // global basis (see Authorization section above).
  176  
  177: var storage = gcloud.storage({
  178    keyFilename: '/path/to/keyfile.json',
  179    projectId: 'my-project'

/Users/ryanseys/gcloud-node/system-test/bigquery.js:
   29  var gcloud = require('../lib')(env);
   30  var bigquery = gcloud.bigquery();
   31: var storage = gcloud.storage();
   32  
   33  describe('BigQuery', function() {

/Users/ryanseys/gcloud-node/system-test/storage.js:
   30  
   31  var env = require('./env.js');
   32: var storage = require('../lib/storage')(env);
   33  
   34  var BUCKET_NAME = generateBucketName();

/Users/ryanseys/gcloud-node/test/storage/file.js:
 1330  
 1331      beforeEach(function() {
 1332:       var storage = bucket.storage;
 1333        storage.makeAuthorizedRequest_.getCredentials = function(callback) {
 1334          callback(null, credentials);
 ....
 1530  
 1531      beforeEach(function() {
 1532:       var storage = bucket.storage;
 1533        storage.makeAuthorizedRequest_.getCredentials = function(callback) {
 1534          callback(null, credentials);

/Users/ryanseys/gcloud-node/test/storage/index.js:
   26  
   27  describe('Storage', function() {
   28:   var storage;
   29  
   30    beforeEach(function() {

stephenplusplus · 2015-06-17T16:57:01Z

I was going to leave the tests untouched, since the use of var storage makes more sense for us (the developers of this project) in the Storage->storage relationship.

Good catch on the readme.

stephenplusplus · 2015-06-17T16:59:01Z

Got the readme.

ryanseys · 2015-06-17T17:21:27Z

SGTM

docs: var storage -> var gcs;

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-language).

@summer-ji-eng

- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.1](https://www.github.com/googleapis/nodejs-dlp/compare/v3.2.0...v3.2.1) (2021-11-03) ### Bug Fixes * **deps:** update dependency mime to v3 ([#663](https://www.github.com/googleapis/nodejs-dlp/issues/663)) ([5d33ead](https://www.github.com/googleapis/nodejs-dlp/commit/5d33ead5c207511a2ef3d268dd804eabc20408d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 17, 2015

stephenplusplus added docs api: storage Issues related to the Cloud Storage API. labels Jun 17, 2015

docs: var storage -> var gcs;

197c334

stephenplusplus force-pushed the spp--docs-storage-to-gcs branch from e8d197e to 197c334 Compare June 17, 2015 16:58

ryanseys added a commit that referenced this pull request Jun 17, 2015

Merge pull request #664 from stephenplusplus/spp--docs-storage-to-gcs

0822aaa

docs: var storage -> var gcs;

ryanseys merged commit 0822aaa into googleapis:master Jun 17, 2015

sofisl mentioned this pull request Sep 27, 2022

migrate code from googleapis/nodejs-video-intelligence #3374

Closed

4 tasks

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

This was referenced Nov 9, 2022

migrate code from googleapis/nodejs-video-intelligence #3507

Closed

migrate code from googleapis/nodejs-video-intelligence #3519

Merged

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: var storage -> var gcs; #664

docs: var storage -> var gcs; #664

Uh oh!

stephenplusplus commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Fixes #619 #619

Uh oh!

jgeewax commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Uh oh!

stephenplusplus commented Jun 17, 2015

Uh oh!

stephenplusplus commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

docs: var storage -> var gcs; #664

docs: var storage -> var gcs; #664

Uh oh!

Conversation

stephenplusplus commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Fixes #619 #619

Uh oh!

jgeewax commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Uh oh!

stephenplusplus commented Jun 17, 2015

Uh oh!

stephenplusplus commented Jun 17, 2015

Uh oh!

ryanseys commented Jun 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants