Skip to content

support 'fullTextAnnotation' temporary #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dankang wants to merge 1 commit into from
Closed

support 'fullTextAnnotation' temporary #2035

dankang wants to merge 1 commit into from

Conversation

@dankang
Copy link

@dankang dankang commented Mar 1, 2017 •
edited
Loading

@dankang
support 'fullTextAnnotation' temporary
b12e15f 
* fix below error from 'fullTextAnnotatin'
* TypeError: formatMethodMap[type] is not a function
* google-cloud/node_modules/@google-cloud/vision/src/index.js:538:39
@googlebot
Copy link

googlebot commented Mar 1, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 1, 2017
@dankang
Copy link
Author

dankang commented Mar 1, 2017

I signed it!

@googlebot
Copy link

googlebot commented Mar 1, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 1, 2017
@calibr calibr mentioned this pull request Mar 1, 2017
Closed
@stephenplusplus stephenplusplus mentioned this pull request Mar 2, 2017
Merged
@stephenplusplus
Copy link
Contributor

stephenplusplus commented Mar 3, 2017

Thank you for this @dankang! @callmehiphop just made a hotfix release in #2044.

@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dankang @googlebot @stephenplusplus