Skip to content

Conversation

@callmehiphop
Copy link
Contributor

Breaking changes ahead! ⚠️

This adds Promise support for the @google-cloud/compute module!

Summary of changes

The following methods previously returned a stream in the event that the callback parameter was omitted. This functionality has since moved to a different method entirely.

  • Compute#getAddresses -> Compute#getAddressesStream
  • Compute#getAutoscalers -> Compute#getAutoscalersStream
  • Compute#getDisks -> Compute#getDisksStream
  • Compute#getInstanceGroups -> Compute#getInstanceGroupsStream
  • Compute#getFirewalls -> Compute#getFirewallsStream
  • Compute#getHealthChecks -> Compute#getHealthChecksStream
  • Compute#getMachineTypes -> Compute#getMachineTypesStream
  • Compute#getNetworks -> Compute#getNetworksStream
  • Compute#getOperations -> Compute#getOperationsStream
  • Compute#getRegions -> Compute#getRegionsStream
  • Compute#getRules -> Compute#getRulesStream
  • Compute#getServices -> Compute#getServicesStream
  • Compute#getSnapshots -> Compute#getSnapshotsStream
  • Compute#getSubnetworks -> Compute#getSubnetworksStream
  • Compute#getVMs -> Compute#getVMsStream
  • Compute#getZones -> Compute#getZonesStream
  • InstanceGroup#getVMs -> InstanceGroup#getVMsStream
  • Network#getFirewalls -> Network#getFirewallsStream
  • Network#getSubnetworks -> Network#getSubnetworksStream
  • Region#getAddresses -> Region#getAddressesStream
  • Region#getOperations -> Region#getOperationsStream
  • Region#getRules -> Region#getRulesStream
  • Region#getSubnetworks -> Region#getSubnetworksStream
  • Zone#getAutoscalers -> Zone#getAutoscalersStream
  • Zone#getDisks -> Zone#getDisksStream
  • Zone#getInstanceGroups -> Zone#getInstanceGroupsStream
  • Zone#getMachineTypes -> Zone#getMachineTypesStream
  • Zone#getOperations -> Zone#getOperationsStream
  • Zone#getVMs -> Zone#getVMsStream

Each callback accepting change has also been updated to return a Promise instance in the event that thecallback was omitted.

@callmehiphop callmehiphop added the api: compute Issues related to the Compute Engine API. label Oct 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2016
@callmehiphop callmehiphop mentioned this pull request Oct 17, 2016
48 tasks
@stephenplusplus stephenplusplus merged commit 764f010 into googleapis:master Oct 17, 2016
sofisl pushed a commit that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants