compute: add promise support #1703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes ahead!⚠️
Summary of changes
The following methods previously returned a
streamin the event that thecallbackparameter was omitted. This functionality has since moved to a different method entirely.Compute#getAddresses->Compute#getAddressesStreamCompute#getAutoscalers->Compute#getAutoscalersStreamCompute#getDisks->Compute#getDisksStreamCompute#getInstanceGroups->Compute#getInstanceGroupsStreamCompute#getFirewalls->Compute#getFirewallsStreamCompute#getHealthChecks->Compute#getHealthChecksStreamCompute#getMachineTypes->Compute#getMachineTypesStreamCompute#getNetworks->Compute#getNetworksStreamCompute#getOperations->Compute#getOperationsStreamCompute#getRegions->Compute#getRegionsStreamCompute#getRules->Compute#getRulesStreamCompute#getServices->Compute#getServicesStreamCompute#getSnapshots->Compute#getSnapshotsStreamCompute#getSubnetworks->Compute#getSubnetworksStreamCompute#getVMs->Compute#getVMsStreamCompute#getZones->Compute#getZonesStreamInstanceGroup#getVMs->InstanceGroup#getVMsStreamNetwork#getFirewalls->Network#getFirewallsStreamNetwork#getSubnetworks->Network#getSubnetworksStreamRegion#getAddresses->Region#getAddressesStreamRegion#getOperations->Region#getOperationsStreamRegion#getRules->Region#getRulesStreamRegion#getSubnetworks->Region#getSubnetworksStreamZone#getAutoscalers->Zone#getAutoscalersStreamZone#getDisks->Zone#getDisksStreamZone#getInstanceGroups->Zone#getInstanceGroupsStreamZone#getMachineTypes->Zone#getMachineTypesStreamZone#getOperations->Zone#getOperationsStreamZone#getVMs->Zone#getVMsStreamEach callback accepting change has also been updated to return a
Promiseinstance in the event that thecallbackwas omitted.