Skip to content

Conversation

@swcloud
Copy link
Contributor

@swcloud swcloud commented Aug 31, 2016

Fixes #1463
Fixes #1549

auto-generated:
publisher_api.js
publisher_client_config.json
subscriber_api.js
subscriber_client_config.json

v1/index.js: manually written
index.js and package.json: manually modified

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2016
@stephenplusplus
Copy link
Contributor

Thanks! There are just a couple of linting issues JSHint had:

$ npm run lint
> google-cloud-node@ lint /home/travis/build/GoogleCloudPlatform/google-cloud-node
> jshint scripts/ packages/ system-test/ test/ && jscs packages/ system-test/ test/

packages/pubsub/src/v1/publisher_api.js: line 500, col 2, Unnecessary semicolon.
packages/pubsub/src/v1/subscriber_api.js: line 683, col 2, Unnecessary semicolon.

@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Aug 31, 2016
@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Changes Unknown when pulling 8a415fe on swcloud:gapic-codegen-pubsub into * on GoogleCloudPlatform:master*.

@swcloud
Copy link
Contributor Author

swcloud commented Sep 1, 2016

@stephenplusplus Is there anyway to kickstart the Travis CI build again? The test failure on NodeJs 4 and 0.12 seemed strange to me. I run 'npm test' on my local machine which has node 4.4.7 without any problem.

"extend": "^3.0.0",
"google-gax": "^0.6.0",
"is": "^3.0.1",
"lodash": "^4.15.0",

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor

We've been having some Travis inconsistencies lately between versions, unrelated to any changes here. It looks like the tests have been re-run and passed successfully in the meantime 👍

@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Changes Unknown when pulling 7b6b5cd on swcloud:gapic-codegen-pubsub into * on GoogleCloudPlatform:master*.

@stephenplusplus
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants