updated cluster links and option handling #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
Contributor
Author
|
@lesv we noticed that one can optionally provide an API key instead of a keyfile or default application creds. Is there a standard way of providing said key? |
Contributor
|
Throwing a test on here would be good. |
| fakeUtil.normalizeArguments = normalizeArguments; | ||
| }); | ||
|
|
||
| it('should leave the original options unaltered', function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Jul 11, 2023
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobufjs-cli](https://togithub.com/protobufjs/protobuf.js) | [`1.1.0` -> `1.1.1`](https://renovatebot.com/diffs/npm/protobufjs-cli/1.1.0/1.1.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protobufjs/protobuf.js</summary> ### [`v1.1.1`](https://togithub.com/protobufjs/protobuf.js/releases/tag/protobufjs-cli-v1.1.1): protobufjs-cli: v1.1.1 [Compare Source](https://togithub.com/protobufjs/protobuf.js/compare/protobufjs-cli-v1.1.0...protobufjs-cli-v1.1.1) ##### Bug Fixes - **cli:** fix relative path to Google pb files ([#​1859](https://togithub.com/protobufjs/protobuf.js/issues/1859)) ([e42eea4](https://togithub.com/protobufjs/protobuf.js/commit/e42eea4868b11f4a07934804a56683321ed191e2)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gax-nodejs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4wIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 things: