speech: initial support #1407

jmdobry · 2016-07-02T04:11:46Z

Add support for the Speech API (v1beta1)!

CONTRIBUTING.md

 - **GCLOUD_TESTS_KEY**: The path to the JSON key file.
 - ***GCLOUD_TESTS_API_KEY*** (*optional*): An API key that can be used to test the Translate API.
 - ***GCLOUD_TESTS_DNS_DOMAIN*** (*optional*): A domain you own managed by Google Cloud DNS (expected format: `'gcloud-node.com.'`).
+- ***GCLOUD_TESTS_BIGTABLE_ZONE*** (*optional*): A zone containing a Google Cloud Bigtable cluster.


lib/speech/index.js

+    baseUrl: 'speech.googleapis.com',
+    projectIdRequired: false,
+    service: 'speech',
+    apiVersion: 'v1',


stephenplusplus · 2016-07-11T21:46:53Z

Sorry for being quiet on this. It looks great to me so far... I'll dive in deeper asap. Thanks!

jmdobry · 2016-07-12T18:24:08Z

Yeah, this is ready for review. I was looking at using something like https://github.com/audiocogs/aurora.js to detect encoding and sampleRate, but after some testing I couldn't get it to work reliably (maybe because the Speech API supports only a small set of encodings?). Also https://github.com/audiocogs/aurora.js requires some native dependencies, which I'm not sure we'd want.

If some day another API also implements the Operations service interface, then we could extract the operations-related code out of the speech code. operation.js is already generally re-usable, it just has speech-specific comments in it. The getOperation method is easily generalizable as well. Maybe the operations code could move into grpc-service.js and be configurable in the service config object during instantiation.

stephenplusplus · 2016-07-12T18:26:53Z

Assigned to @callmehiphop for a review.

lib/common/grpc-service.js

+  if (!this.grpcCredentials) {
+    // We must establish an authClient to give to grpc.
+    this.getGrpcCredentials_(function(err, credentials) {
+      if (err) {


packages/speech/src/index.js

+ * //-
+ * // <h3>Run speech recognition over a remote file</h3>
+ * //
+ * // *Note: This is not an officially supported feature of the Speech API.


stephenplusplus · 2016-09-12T20:16:22Z

Pulled this out from the now-squashed commit comment:

IMO we should do stuff in this order

Merge Speech PR

Release Speech API (v0.1.0)

Add dependency for Speech on umbrella package

Release umbrella package.

@callmehiphop many changes made, PTAL!

callmehiphop · 2016-09-19T15:18:19Z

Looks like there are still some linting issues lingering about.

jmdobry · 2016-09-19T19:46:19Z

Any idea when this will get merged?

jmdobry · 2016-09-19T21:37:46Z

Assuming the tests pass after my most recent commit, I think we can:

Merge to master
Cut a 0.1.0 release
Open a new PR that adds the autogen layer for Speech
1. Re-write hand-written methods as necessary to use the autogen layer instead of the grpc stuff in google-cloud-common
Cut a 0.2.0 once the autogen PR is merged

packages/speech/src/index.js

+ * // Run speech recognition over raw file contents.
+ * //-
+ * speech.recognize({
+ *   content: fs.readFileSync('./bridge.raw')


callmehiphop · 2016-09-19T21:55:35Z

@jmdobry I might have misunderstood, but I thought we agreed to wait until next Monday to cut the release so we could try and get vtk in as well.

jmdobry · 2016-09-19T22:35:42Z

Maybe I misunderstand too. Are we talking about just adding the autogen layer, or adding the autogen layer and changing the hand-written layer to use autogen?

stephenplusplus · 2016-09-19T23:46:46Z

I obviously wasn't at the meeting, but just a thought... if we can get this out now, let's just do that :)

Co-authored-by: Alexander Fenster <[email protected]>

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 2, 2016

jgeewax reviewed Jul 4, 2016
View reviewed changes

stephenplusplus added the api: speech Issues related to the Speech-to-Text API. label Jul 6, 2016

pbogle reviewed Jul 7, 2016
View reviewed changes

lib/speech/index.js Outdated

baseUrl: 'speech.googleapis.com',

projectIdRequired: false,

service: 'speech',

apiVersion: 'v1',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 11, 2016

stephenplusplus assigned callmehiphop Jul 12, 2016

callmehiphop reviewed Jul 13, 2016
View reviewed changes

lib/common/grpc-service.js

if (!this.grpcCredentials) {

// We must establish an authClient to give to grpc.

this.getGrpcCredentials_(function(err, credentials) {

if (err) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop reviewed Sep 12, 2016
View reviewed changes

packages/speech/src/index.js Outdated

* //-

* // <h3>Run speech recognition over a remote file</h3>

* //

* // *Note: This is not an officially supported feature of the Speech API.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

remove dependency and address PR feedback

e184d1f

stephenplusplus added 3 commits September 12, 2016 18:12

remove more formatting blunders

ec87948

clarify data event

e2f48ba

remove speech from bundled pkg for now

123c734

Fix lint error.

4c5c4c3

callmehiphop reviewed Sep 19, 2016

View reviewed changes

packages/speech/src/index.js

* // Run speech recognition over raw file contents.

* //-

* speech.recognize({

* content: fs.readFileSync('./bridge.raw')

This comment was marked as spam.

Sign in to view

callmehiphop merged commit d24209a into googleapis:master Sep 20, 2016

jmdobry deleted the speech branch September 28, 2016 17:38

sofisl pushed a commit that referenced this pull request Jan 24, 2023

speech: initial support (#1407)

72d0af0

sofisl pushed a commit that referenced this pull request Jan 25, 2023

speech: initial support (#1407)

885720d

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore(deps): update dependency mkdirp to v2 (#1407)

9472d73

Co-authored-by: Alexander Fenster <[email protected]>

speech: initial support #1407

speech: initial support #1407

Uh oh!

Conversation

jmdobry commented Jul 2, 2016 • edited by stephenplusplus Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stephenplusplus commented Jul 11, 2016

Uh oh!

jmdobry commented Jul 12, 2016

Uh oh!

stephenplusplus commented Jul 12, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stephenplusplus commented Sep 12, 2016

Uh oh!

callmehiphop commented Sep 19, 2016

Uh oh!

jmdobry commented Sep 19, 2016

Uh oh!

jmdobry commented Sep 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

callmehiphop commented Sep 19, 2016

Uh oh!

jmdobry commented Sep 19, 2016

Uh oh!

stephenplusplus commented Sep 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmdobry commented Jul 2, 2016 •

edited by stephenplusplus

Loading