core: implement retry strategy for grpc requests #1272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
Is it possible to use retry request directly? It accepts a custom request function. If it's close, but kind of a hack, maybe it just needs a pr to generalize it. |
Contributor
Author
|
I initially did go down this route but it started to get pretty hacky, so I gave up on it. However if you think a PR there is the way to go, I'd be more than happy to try and tackle that. |
Contributor
|
If it's possible without getting into hack territory, I think that would be awesome. |
|
@callmehiphop this works, thanks! |
Contributor
Author
|
Closing in favor of #1273 |
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobufjs](https://protobufjs.github.io/protobuf.js/) ([source](https://togithub.com/protobufjs/protobuf.js)) | [`6.11.2` -> `6.11.3`](https://renovatebot.com/diffs/npm/protobufjs/6.11.2/6.11.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protobufjs/protobuf.js</summary> ### [`v6.11.3`](https://togithub.com/protobufjs/protobuf.js/releases/tag/v6.11.3) [Compare Source](https://togithub.com/protobufjs/protobuf.js/compare/v6.11.2...v6.11.3) ##### [6.11.3](https://togithub.com/protobufjs/protobuf.js/compare/v6.11.2...v6.11.3) (2022-05-20) ##### Bug Fixes - **deps:** use eslint 8.x ([#​1728](https://togithub.com/protobufjs/protobuf.js/issues/1728)) ([a8681ce](https://togithub.com/protobufjs/protobuf.js/commit/a8681ceab4763e706a848121a2dde56791b89eea)) - do not let setProperty change the prototype ([#​1731](https://togithub.com/protobufjs/protobuf.js/issues/1731)) ([b5f1391](https://togithub.com/protobufjs/protobuf.js/commit/b5f1391dff5515894830a6570e6d73f5511b2e8f)) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gax-nodejs).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1265
This adds a retry with backoff strategy for gRPC requests. Currently it will only attempt to retry for gRPC error code 14 (service unavailable).
@heidmotron @leonardpunt @jmdobry if any of you would like to test if this resolves your issues, that would be awesome :)