-
Notifications
You must be signed in to change notification settings - Fork 640
storage: add file#save #1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add file#save #1233
Conversation
test/storage/file.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe.only('save', function() { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
83f95b0 to
495bc0a
Compare
| /** | ||
| * Write arbitrary data to a file. | ||
| * | ||
| * *This is a convenience method which wraps |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@stephenplusplus I realize this is just a convenience method, but what are your feelings on adding a system-test? |
495bc0a to
92a7e23
Compare
|
Added! |
|
Thanks for doing this! |
|
Thank you for the idea :) |
Fixes #1179
This adds
file#save, which is a simple wrapper aroundfile#createWriteStream: