Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Apr 15, 2016

Fixes #1179

This adds file#save, which is a simple wrapper around file#createWriteStream:

file.save(new Buffer('buffer'), function(err) {});
file.save('string', function(err) {});

@stephenplusplus stephenplusplus added the api: storage Issues related to the Cloud Storage API. label Apr 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-76.9%) to 23.146% when pulling 83f95b0 on stephenplusplus:spp--1179 into 8d38290 on GoogleCloudPlatform:master.

});
});

describe.only('save', function() {

This comment was marked as spam.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 495bc0a on stephenplusplus:spp--1179 into 8d38290 on GoogleCloudPlatform:master.

/**
* Write arbitrary data to a file.
*
* *This is a convenience method which wraps

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@callmehiphop
Copy link
Contributor

@stephenplusplus I realize this is just a convenience method, but what are your feelings on adding a system-test?

@stephenplusplus
Copy link
Contributor Author

Added!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 92a7e23 on stephenplusplus:spp--1179 into 8d38290 on GoogleCloudPlatform:master.

@callmehiphop callmehiphop merged commit 5199cad into googleapis:master Apr 15, 2016
@asciimike
Copy link

Thanks for doing this!

@stephenplusplus
Copy link
Contributor Author

Thank you for the idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants