Skip to content

chore: generate new client #9155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoeWang1127 wants to merge 2 commits into from
Closed

chore: generate new client #9155

JoeWang1127 wants to merge 2 commits into from

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Feb 24, 2023

No description provided.

@JoeWang1127 JoeWang1127 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 24, 2023
@JoeWang1127
Copy link
Contributor Author

JoeWang1127 commented Feb 24, 2023

@suztomo, this is the generated library after the fix of post-processor.

Java GraalVM Native Image test failed with the following output, it seems like not relevant to the generated library?

[INFO] Reactor Summary:
[INFO]
[INFO] Google Cloud Vertex AI Parent 3.13.0-SNAPSHOT ...... SUCCESS [  1.458 s]
[INFO] proto-google-cloud-aiplatform-v1beta1 0.29.0-SNAPSHOT SUCCESS [  1.161 s]
[INFO] proto-google-cloud-aiplatform-v1 3.13.0-SNAPSHOT ... SUCCESS [  0.135 s]
[INFO] grpc-google-cloud-aiplatform-v1beta1 0.29.0-SNAPSHOT SUCCESS [  0.086 s]
[INFO] grpc-google-cloud-aiplatform-v1 3.13.0-SNAPSHOT .... SUCCESS [  0.087 s]
[INFO] Google Cloud Vertex AI 3.13.0-SNAPSHOT ............. SUCCESS [07:52 min]
[INFO] Google Compute Engine Parent 1.22.0-SNAPSHOT ....... SUCCESS [  0.053 s]
[INFO] proto-google-cloud-compute-v1 1.22.0-SNAPSHOT ...... SUCCESS [  0.228 s]
[INFO] Google Compute Engine 1.22.0-SNAPSHOT .............. FAILURE [23:24 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  31:25 min
[INFO] Finished at: 2023-02-24T01:30:09Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.graalvm.buildtools:native-maven-plugin:0.9.18:test (test-native) on project google-cloud-compute: Execution of /tmpfs/src/github/google-cloud-java/java-compute/google-cloud-compute/target/native-tests --xml-output-dir /tmpfs/src/github/google-cloud-java/java-compute/google-cloud-compute/target/native-test-reports -Djunit.platform.listeners.uid.tracking.output.dir=/tmpfs/src/github/google-cloud-java/java-compute/google-cloud-compute/target/test-ids returned non-zero result -> [Help 1]

@suztomo
Copy link
Member

suztomo commented Feb 24, 2023 •
edited
Loading

Can you retry? It seems irrelevant.

Can you add comments for the groupIDs you checked?

@JoeWang1127 JoeWang1127 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2023
JoeWang1127
JoeWang1127 commented Feb 24, 2023
View reviewed changes
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the following group ids.

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
<?xml version="1.0"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.maps</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.google.maps</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
<version>0.0.1-SNAPSHOT</version><!-- {x-version-update:google-maps-mapsplatformdatasets:current} -->
</dependency>
<dependency>
<groupId>com.google.maps.api.grpc</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
<version>0.0.1-SNAPSHOT</version><!-- {x-version-update:grpc-google-maps-mapsplatformdatasets-v1alpha:current} -->
</dependency>
<dependency>
<groupId>com.google.maps.api.grpc</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
<?xml version="1.0"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.maps</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
<name>Google Maps Platform Datasets API</name>
<description>Maps Platform Datasets API Maps Platform Datasets API.</description>
<parent>
<groupId>com.google.maps</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
</dependency>

<dependency>
<groupId>com.google.maps.api.grpc</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
</dependency>

<dependency>
<groupId>com.google.maps.api.grpc</groupId>
Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@JoeWang1127
Copy link
Contributor Author

JoeWang1127 commented Feb 24, 2023

The GraalVM Native Image test passed the 2nd time.

@suztomo
Copy link
Member

suztomo commented Feb 24, 2023

I merged main to see group_id_check_for_maps_libraries result.

@suztomo
Copy link
Member

suztomo commented Feb 24, 2023 •
edited
Loading

It passed:

https://github.com/googleapis/google-cloud-java/actions/runs/4265425857/jobs/7424743941

Passed java-maps-addressvalidation/pom.xml
Passed java-maps-addressvalidation/grpc-google-maps-addressvalidation-v1/pom.xml
Passed java-maps-addressvalidation/google-maps-addressvalidation/pom.xml
Passed java-maps-addressvalidation/proto-google-maps-addressvalidation-v1/pom.xml
Passed java-maps-addressvalidation/google-maps-addressvalidation-bom/pom.xml
Passed java-maps-mapsplatformdatasets/pom.xml
Passed java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
Passed java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
Passed java-maps-mapsplatformdatasets/proto-google-maps-mapsplatformdatasets-v1alpha/pom.xml
Passed java-maps-mapsplatformdatasets/grpc-google-maps-mapsplatformdatasets-v1alpha/pom.xml
Passed java-maps-routing/pom.xml
Passed java-maps-routing/google-maps-routing/pom.xml
Passed java-maps-routing/proto-google-maps-routing-v2/pom.xml
Passed java-maps-routing/google-maps-routing-bom/pom.xml
Passed java-maps-routing/grpc-google-maps-routing-v2/pom.xml
All group IDs start with com.google.maps. Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoeWang1127 @suztomo @yoshi-kokoro