Skip to content

Modified methods in ChangeRequest. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mderka merged 5 commits into from
Apr 4, 2016
Merged

Modified methods in ChangeRequest. #849

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52567fd
Modified methods in ChangeRequest.
mderka Apr 4, 2016
3becc74
Reworded the documentation.
mderka Apr 4, 2016
8ad3e89
Fixed the snipped and README. Removed possible NPE.
mderka Apr 4, 2016
0f3dc9a
One more throw and snippet.
mderka Apr 4, 2016
74a4cf6
Rephrased doc and improved IT.
mderka Apr 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions gcloud-java-dns/src/main/java/com/google/gcloud/dns/ChangeRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,26 +156,31 @@ public ChangeRequest applyTo(String zoneName, Dns.ChangeRequestOption... options

/**
* Retrieves the up-to-date information about the change request from Google Cloud DNS. Parameter

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

* {@code options} can be used to restrict the fields to be updated in the same way as in {@link
* Dns#getChangeRequest(String, String, Dns.ChangeRequestOption...)}. If {@code options} are
* provided, any field other than generatedId which is not included in the {@code options} will be
* {@code null} regardless whether they are initialized or not in {@code this} instance.
* {@code options} can be used to restrict the fields to be included in the updated object the
* same way as in {@link Dns#getChangeRequest(String, String, Dns.ChangeRequestOption...)}. If
* {@code options} are provided, any field other than generatedId which is not included in the
* {@code options} will be {@code null} regardless of whether they are initialized or not in
* {@code this} instance.
*
* @return an object containing the updated information
*/
public ChangeRequest reload(Dns.ChangeRequestOption... options) {
return dns.getChangeRequest(zone, this.generatedId(), options);
return dns.getChangeRequest(zone, generatedId(), options);
}

/**
* Returns {@code true} if the change request has been completed. The function makes an API call
* to Google Cloud DNS in order request the status update.
* to Google Cloud DNS in order request the status update only if the status of the change request

This comment was marked as spam.

Sign in to view

* is {@link Status#PENDING}. If the status is already {@link Status#DONE}, the method returns
* {@code true} without an API call.
*/
public boolean isDone() {
if (status() == Status.DONE) {
return true;
} else {
ChangeRequest updated = reload(Dns.ChangeRequestOption.fields(Dns.ChangeRequestField.STATUS));
return updated.status() == Status.DONE;
}
ChangeRequest updated = reload(Dns.ChangeRequestOption.fields(Dns.ChangeRequestField.STATUS));
return updated.status() == Status.DONE;

}

@Override
Expand Down