spanner-jdbc: Do not close TransactionManager twice #6095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not close the TransactionManager twice in two different threads. The fireAndForgetRollbackAndCloseTxManager(...) call will close the transaction manager after the commit. The main thread should not also close the transaction manager.
googlebot
added
the
cla: yes
kolea2
approved these changes
Aug 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #6095 +/- ##
============================================
- Coverage 47.38% 47.38% -0.01%
+ Complexity 27182 27180 -2
============================================
Files 2523 2523
Lines 274581 274580 -1
Branches 31380 31380
============================================
- Hits 130123 130119 -4
- Misses 134850 134851 +1
- Partials 9608 9610 +2
Continue to review full report at Codecov.
|
This was referenced Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close the TransactionManager two different threads. The fireAndForgetRollbackAndCloseTxManager(...) call will close the transaction manager after the commit. The main thread should not also close the transaction manager.
Updates #6075