Skip to content

Firestore: Add note about potential flakiness in the new Watch test #5928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenWhitehead merged 3 commits into from
Jul 31, 2019
Merged

Firestore: Add note about potential flakiness in the new Watch test #5928

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a21a669
Firestore: Add note about potential flakiness in the new Watch test
schmidt-sebastian Jul 30, 2019
8613165
Update ITSystemTest.java
schmidt-sebastian Jul 30, 2019
9d544bc
Update ITSystemTest.java
schmidt-sebastian Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ents/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,10 @@ public void queryWatch() throws Exception {
// case there is a hang during the test the whole suite isn't taken with it)
// D. After all updates have been performed and the expected number of events have been
// received, assertions on the events will be performed.
//
// Note: There is a potential that this test fails if the Firestore backend chooses not to send
// us individual changes for every document update, but rather merges two or more changes into
// a single event. We have, however, not seen any failures during thousands of test runs.
ListenerRegistration registration = null;
final ExecutorService updatesExecutor = Executors.newCachedThreadPool();

Expand Down