Skip to content

feat: allow endpoint override on Publisher/Subscriber #5915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 1 commit into from
Jul 30, 2019
Merged

feat: allow endpoint override on Publisher/Subscriber #5915

chingor13 merged 1 commit into from
Jul 30, 2019

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jul 29, 2019

Fixes #5792

@chingor13 chingor13 requested a review from kamalaboulhosn July 29, 2019 18:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2019
kamalaboulhosn
kamalaboulhosn reviewed Jul 29, 2019
View reviewed changes
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
.setCredentialsProvider(builder.credentialsProvider)
.setExecutorProvider(FixedExecutorProvider.create(executor))
.setTransportChannelProvider(builder.channelProvider);
.setTransportChannelProvider(builder.channelProvider)
Copy link

@kamalaboulhosn kamalaboulhosn Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the existence of setEndpoint, one would create a custom TransportChannelProvider and set the endpoint in there. If one does that and calls setEndpoint, which one will win?

Copy link
Contributor Author

@chingor13 chingor13 Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the TransportChannelProvider#needsEndpoint(), then the value configured with setEndpoint() will take effect via TransportChannelProvider#withEndpoint(String). So a custom TransportChannelProvider that specifies an endpoint would not be overwritten.

See https://github.com/googleapis/gax-java/blob/fd5740a2726d0ab3f3124351ed0384911fa8f5c2/gax/src/main/java/com/google/api/gax/rpc/ClientContext.java#L154-L156

@chingor13 chingor13 merged commit 34b20f8 into googleapis:master Jul 30, 2019
@chingor13 chingor13 deleted the pubsub-endpoint-override branch July 30, 2019 17:40
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PubSub: support setEndpoint on Publisher/Subscriber builders

3 participants

@chingor13 @kamalaboulhosn @googlebot