Skip to content

Expose FullEntity::fromPb and Value::fromPb #5759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 1 commit into from
Jul 30, 2019
Merged

Expose FullEntity::fromPb and Value::fromPb #5759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cloud-clients/google-cloud-datastore/src/main/java/com/google/cloud/datastore/Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public static Builder newBuilder(Key key, FullEntity<?> copyFrom) {
return new Builder(key, copyFrom);
}

static Entity fromPb(com.google.datastore.v1.Entity entityPb) {
public static Entity fromPb(com.google.datastore.v1.Entity entityPb) {
return new Builder().fill(entityPb).build();
}
}
2 changes: 1 addition & 1 deletion ...d-clients/google-cloud-datastore/src/main/java/com/google/cloud/datastore/FullEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static <K extends IncompleteKey> Builder<K> newBuilder(FullEntity<K> copy
return new Builder<>(copyFrom);
}

static FullEntity<?> fromPb(com.google.datastore.v1.Entity entityPb) {
public static FullEntity<?> fromPb(com.google.datastore.v1.Entity entityPb) {
return new Builder<>().fill(entityPb).build();
}
}
2 changes: 1 addition & 1 deletion ...-cloud-clients/google-cloud-datastore/src/main/java/com/google/cloud/datastore/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ com.google.datastore.v1.Value toPb() {
return getType().getMarshaller().toProto(this);
}

static Value<?> fromPb(com.google.datastore.v1.Value proto) {
public static Value<?> fromPb(com.google.datastore.v1.Value proto) {
ValueTypeCase descriptorId = proto.getValueTypeCase();
ValueType valueType = ValueType.getByDescriptorId(descriptorId.getNumber());
return valueType == null
Expand Down