Skip to content

Add additional assertions to DatabaseClientImplTest. #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 2 commits into from
Jul 10, 2019
Merged

Add additional assertions to DatabaseClientImplTest. #5715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f81ad6
Add additional assertions to DatabaseClientImplTest.
kolea2 Jul 10, 2019
2fd2378
code format
kolea2 Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...s/google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseClientImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ public void testPartitionedDmlDoesNotTimeout() throws Exception {
DatabaseClient client =
spanner.getDatabaseClient(DatabaseId.of("[PROJECT]", "[INSTANCE]", "[DATABASE]"));

assertThat(
spanner.getOptions().getPartitionedDmlTimeout(), is(equalTo(Duration.ofHours(2L))));

// PDML should not timeout with these settings.
long updateCount = client.executePartitionedUpdate(UPDATE_STATEMENT);
assertThat(updateCount, is(equalTo(UPDATE_COUNT)));
Expand Down Expand Up @@ -228,6 +231,9 @@ public void testPartitionedDmlWithTimeout() throws Exception {
DatabaseClient client =
spanner.getDatabaseClient(DatabaseId.of("[PROJECT]", "[INSTANCE]", "[DATABASE]"));

assertThat(
spanner.getOptions().getPartitionedDmlTimeout(), is(equalTo(Duration.ofMillis(1L))));

// PDML should timeout with these settings.
try {
client.executePartitionedUpdate(UPDATE_STATEMENT);
Expand Down