Skip to content

ResourceManager: Fix Project properties. #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 3 commits into from
Jun 27, 2019
Merged

ResourceManager: Fix Project properties. #5577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5643ff7
made public ResourceId and added method of()
Jun 27, 2019
9e31ac2
fix setParent
Jun 27, 2019
9884529
modified code
Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../google-cloud-resourcemanager/src/main/java/com/google/cloud/resourcemanager/Project.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ Builder setCreateTimeMillis(Long createTimeMillis) {
}

@Override
Builder setParent(ResourceId parent) {
public Builder setParent(ResourceId parent) {
infoBuilder.setParent(parent);
return this;
}
Expand Down
14 changes: 9 additions & 5 deletions ...gle-cloud-resourcemanager/src/main/java/com/google/cloud/resourcemanager/ProjectInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public static State[] values() {
}
}

static class ResourceId implements Serializable {
public static class ResourceId implements Serializable {

private static final long serialVersionUID = -325199985993344726L;

Expand All @@ -118,11 +118,15 @@ static class ResourceId implements Serializable {
this.type = checkNotNull(type);
}

String getId() {
public static ResourceId of(String id, String type) {
return new ResourceId(checkNotNull(id), checkNotNull(type));
}

public String getId() {
return id;
}

String type() {
public String getType() {
return type;
}

Expand Down Expand Up @@ -201,7 +205,7 @@ public abstract static class Builder {

abstract Builder setCreateTimeMillis(Long createTimeMillis);

abstract Builder setParent(ResourceId parent);
public abstract Builder setParent(ResourceId parent);

public abstract ProjectInfo build();
}
Expand Down Expand Up @@ -285,7 +289,7 @@ Builder setCreateTimeMillis(Long createTimeMillis) {
}

@Override
Builder setParent(ResourceId parent) {
public Builder setParent(ResourceId parent) {
this.parent = parent;
return this;
}
Expand Down